🌱 WipeDisk annotation #1429
Merged
🌱 WipeDisk annotation #1429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced annotation "wipedisk.hetznerbaremetalhost.infrastructure.cluster.x-k8s.io" Set it to a space seperated list of WWNs or "all". The given disks will be erased with `wipefs -af` before provisioning. Once wipefs was executed the annotation gets removed.
guettli
commented
Aug 9, 2024
syself-bot
bot
added
area/code
syself-bot
bot
added
the
size/M
syself-bot
bot
added
size/L
For error structs, you need to use errors.As().
We might got during `trap`: sed: can't read bash: No such file or directory
janiskemper
approved these changes
Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced annotation "wipedisk.hetznerbaremetalhost.infrastructure.cluster.x-k8s.io"
Set it to a space seperated list of WWNs or "all".
The given disks will be erased with
wipefs -afbefore provisioning.Once wipefs was executed the annotation gets removed.