Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add Singapore location and ap-southeast Network Zone #1420

Merged
merged 1 commit into from
Aug 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion api/v1beta1/hetznercluster_webhook.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ var regionNetworkZoneMap = map[string]string{
"hel1": "eu-central",
"ash": "us-east",
"hil": "us-west",
"sin": "ap-southeast",
}

// SetupWebhookWithManager initializes webhook manager for HetznerCluster.
Expand Down Expand Up @@ -91,7 +92,7 @@ func (r *HetznerCluster) ValidateCreate() (admission.Warnings, error) {
allErrs = append(allErrs, field.Invalid(
field.NewPath("spec", "controlPlaneRegions"),
r.Spec.ControlPlaneRegions,
"wrong control plane region. Should be fsn1, nbg1, hel1, or ash",
"wrong control plane region. Should be fsn1, nbg1, hel1, ash, hil or sin",
))
}
}
Expand Down
4 changes: 2 additions & 2 deletions api/v1beta1/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ type HCloudNetworkSpec struct {

// NetworkZone specifies the HCloud network zone of the private network.
// The zones must be one of eu-central, us-east, or us-west. The default is eu-central.
// +kubebuilder:validation:Enum=eu-central;us-east;us-west
// +kubebuilder:validation:Enum=eu-central;us-east;us-west;ap-southeast
// +kubebuilder:default=eu-central
// +optional
NetworkZone HCloudNetworkZone `json:"networkZone,omitempty"`
Expand All @@ -247,7 +247,7 @@ type NetworkStatus struct {
}

// Region is a Hetzner Location.
// +kubebuilder:validation:Enum=fsn1;hel1;nbg1;ash;hil
// +kubebuilder:validation:Enum=fsn1;hel1;nbg1;ash;hil;sin
type Region string

// HCloudNetworkZone describes the Network zone.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,7 @@ spec:
- nbg1
- ash
- hil
- sin
type: string
sshKeys:
description: SSHKeys specifies the ssh keys that were used for provisioning
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,7 @@ spec:
- nbg1
- ash
- hil
- sin
type: string
type:
default: lb11
Expand All @@ -181,6 +182,7 @@ spec:
- nbg1
- ash
- hil
- sin
type: string
type: array
hcloudNetwork:
Expand All @@ -205,6 +207,7 @@ spec:
- eu-central
- us-east
- us-west
- ap-southeast
type: string
subnetCidrBlock:
default: 10.0.0.0/24
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,7 @@ spec:
- nbg1
- ash
- hil
- sin
type: string
type:
default: lb11
Expand All @@ -211,6 +212,7 @@ spec:
- nbg1
- ash
- hil
- sin
type: string
type: array
hcloudNetwork:
Expand All @@ -236,6 +238,7 @@ spec:
- eu-central
- us-east
- us-west
- ap-southeast
type: string
subnetCidrBlock:
default: 10.0.0.0/24
Expand Down
Loading