Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add Singapore location and ap-southeast Network Zone #1420

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

apricote
Copy link
Contributor

@apricote apricote commented Aug 6, 2024

What this PR does / why we need it:

Add the new location sin (Singapore) and network zone ap-southeast to the CRDs + webhook validations.

The new location was released on 2024-08-06. Learn more at https://docs.hetzner.cloud/changelog#2024-08-06-new-location-singapore

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squash commits
  • include documentation
  • add unit tests

@syself-bot syself-bot bot added size/XS Denotes a PR that changes 0-20 lines, ignoring generated files. area/api Changes made in the api directory labels Aug 6, 2024
@apricote
Copy link
Contributor Author

apricote commented Aug 6, 2024

I dont really know why make verify fails (can reproduce locally). The output does not show any errors/warnings to me. I also did not add any links in this PR that could be broken.

https://github.com/syself/cluster-api-provider-hetzner/actions/runs/10262738794/job/28393040899?pr=1420#step:6:106

 make: *** [Makefile:747: lint-links] Error 2

@janiskemper
Copy link
Contributor

@guettli this is another PR.. The linting fails for all right now. Thanks for the PR @apricote

@guettli
Copy link
Contributor

guettli commented Aug 6, 2024

I dont really know why make verify fails (can reproduce locally).

Don't worry about that. Our link-checker failed on http status 999 of LinkedIn. This will be fixed via #1421

@guettli guettli merged commit f5f143d into syself:main Aug 6, 2024
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Changes made in the api directory size/XS Denotes a PR that changes 0-20 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants