Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Update hetznercluster_types.go #1179

Merged
merged 1 commit into from
Mar 20, 2024
Merged

🌱 Update hetznercluster_types.go #1179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions api/v1beta1/hetznercluster_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,18 +27,18 @@ const (
// apiserver.
ClusterFinalizer = "hetznercluster.infrastructure.cluster.x-k8s.io"
// AllowEmptyControlPlaneAddressAnnotation allows HetznerCluster Webhook
// to skip some validation steps for external managed controle planes.
// to skip some validation steps for externally managed control planes.
AllowEmptyControlPlaneAddressAnnotation = "capi.syself.com/allow-empty-control-plane-address"
)

// HetznerClusterSpec defines the desired state of HetznerCluster.
type HetznerClusterSpec struct {
// HCloudNetworkSpec defines the Network for Hetzner Cloud. If left empty no private Network is configured.
// HCloudNetwork defines details about the private Network for Hetzner Cloud. If left empty, no private Network is configured.
// +optional
HCloudNetwork HCloudNetworkSpec `json:"hcloudNetwork"`

// ControlPlaneRegion consists of a list of HCloud Regions (fsn, nbg, hel). Because HCloud Networks
// have a very low latency we could assume in some use-cases that a region is behaving like a zone
// have a very low latency we could assume in some use cases that a region is behaving like a zone.
// https://kubernetes.io/docs/reference/labels-annotations-taints/#topologykubernetesiozone
ControlPlaneRegions []Region `json:"controlPlaneRegions"`

Expand All @@ -48,7 +48,7 @@ type HetznerClusterSpec struct {
// +optional
ControlPlaneEndpoint *clusterv1.APIEndpoint `json:"controlPlaneEndpoint,omitempty"`

// ControlPlaneLoadBalancer is optional configuration for customizing control plane behavior. Naming convention is from upstream cluster-api project.
// ControlPlaneLoadBalancer is an optional configuration for customizing control plane behavior.
ControlPlaneLoadBalancer LoadBalancerSpec `json:"controlPlaneLoadBalancer,omitempty"`

// +optional
Expand Down
13 changes: 6 additions & 7 deletions config/crd/bases/infrastructure.cluster.x-k8s.io_hetznerclusters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,9 +82,8 @@ spec:
- port
type: object
controlPlaneLoadBalancer:
description: ControlPlaneLoadBalancer is optional configuration for
customizing control plane behavior. Naming convention is from upstream
cluster-api project.
description: ControlPlaneLoadBalancer is an optional configuration
for customizing control plane behavior.
properties:
algorithm:
allOf:
Expand Down Expand Up @@ -160,8 +159,8 @@ spec:
controlPlaneRegions:
description: ControlPlaneRegion consists of a list of HCloud Regions
(fsn, nbg, hel). Because HCloud Networks have a very low latency
we could assume in some use-cases that a region is behaving like
a zone https://kubernetes.io/docs/reference/labels-annotations-taints/#topologykubernetesiozone
we could assume in some use cases that a region is behaving like
a zone. https://kubernetes.io/docs/reference/labels-annotations-taints/#topologykubernetesiozone
items:
description: Region is a Hetzner Location
enum:
Expand All @@ -173,8 +172,8 @@ spec:
type: string
type: array
hcloudNetwork:
description: HCloudNetworkSpec defines the Network for Hetzner Cloud.
If left empty no private Network is configured.
description: HCloudNetwork defines details about the private Network
for Hetzner Cloud. If left empty, no private Network is configured.
properties:
cidrBlock:
default: 10.0.0.0/16
Expand Down
14 changes: 7 additions & 7 deletions config/crd/bases/infrastructure.cluster.x-k8s.io_hetznerclustertemplates.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,9 +103,8 @@ spec:
- port
type: object
controlPlaneLoadBalancer:
description: ControlPlaneLoadBalancer is optional configuration
for customizing control plane behavior. Naming convention
is from upstream cluster-api project.
description: ControlPlaneLoadBalancer is an optional configuration
for customizing control plane behavior.
properties:
algorithm:
allOf:
Expand Down Expand Up @@ -182,8 +181,8 @@ spec:
controlPlaneRegions:
description: ControlPlaneRegion consists of a list of HCloud
Regions (fsn, nbg, hel). Because HCloud Networks have a
very low latency we could assume in some use-cases that
a region is behaving like a zone https://kubernetes.io/docs/reference/labels-annotations-taints/#topologykubernetesiozone
very low latency we could assume in some use cases that
a region is behaving like a zone. https://kubernetes.io/docs/reference/labels-annotations-taints/#topologykubernetesiozone
items:
description: Region is a Hetzner Location
enum:
Expand All @@ -195,8 +194,9 @@ spec:
type: string
type: array
hcloudNetwork:
description: HCloudNetworkSpec defines the Network for Hetzner
Cloud. If left empty no private Network is configured.
description: HCloudNetwork defines details about the private
Network for Hetzner Cloud. If left empty, no private Network
is configured.
properties:
cidrBlock:
default: 10.0.0.0/16
Expand Down
Loading