-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Update hetznercluster_types.go #1179
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janiskemper
requested changes
Feb 21, 2024
syself-bot
bot
added
the
size/XS
Denotes a PR that changes 0-20 lines, ignoring generated files.
label
Feb 29, 2024
Sayanta66
force-pushed
the
sb/hcluster
branch
from
February 29, 2024 06:26
eb9e19f
to
ade244f
Compare
syself-bot
bot
added
size/S
Denotes a PR that changes 20-50 lines, ignoring generated files.
and removed
size/XS
Denotes a PR that changes 0-20 lines, ignoring generated files.
labels
Feb 29, 2024
janiskemper
requested changes
Feb 29, 2024
Sayanta66
force-pushed
the
sb/hcluster
branch
2 times, most recently
from
February 29, 2024 11:56
081a528
to
c0fccf7
Compare
janiskemper
previously approved these changes
Feb 29, 2024
kranurag7
reviewed
Feb 29, 2024
kranurag7
suggested changes
Mar 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description field doesn't match what we have defined on types as comments.
Can you please run make generate-manifests
again and push the same.
Rest, looks good to me.
Co-authored-by: janiskemper <[email protected]> Update api/v1beta1/hetznercluster_types.go Co-authored-by: janiskemper <[email protected]>
janiskemper
approved these changes
Mar 20, 2024
kranurag7
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Added spec descriptions.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs: