Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Update hetznercluster_types.go #1179

Merged
merged 1 commit into from
Mar 20, 2024
Merged

🌱 Update hetznercluster_types.go #1179

merged 1 commit into from
Mar 20, 2024

Conversation

Sayanta66
Copy link
Contributor

What this PR does / why we need it:

Added spec descriptions.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squash commits
  • include documentation
  • add unit tests

@Sayanta66 Sayanta66 marked this pull request as ready for review February 21, 2024 13:29
@syself-bot syself-bot bot added the area/api Changes made in the api directory label Feb 21, 2024
api/v1beta1/hetznercluster_types.go Outdated Show resolved Hide resolved
api/v1beta1/hetznercluster_types.go Outdated Show resolved Hide resolved
api/v1beta1/hetznercluster_types.go Outdated Show resolved Hide resolved
@syself-bot syself-bot bot added the size/XS Denotes a PR that changes 0-20 lines, ignoring generated files. label Feb 29, 2024
@syself-bot syself-bot bot added size/S Denotes a PR that changes 20-50 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-20 lines, ignoring generated files. labels Feb 29, 2024
api/v1beta1/hetznercluster_types.go Outdated Show resolved Hide resolved
@janiskemper janiskemper marked this pull request as draft February 29, 2024 08:28
@Sayanta66 Sayanta66 force-pushed the sb/hcluster branch 2 times, most recently from 081a528 to c0fccf7 Compare February 29, 2024 11:56
janiskemper
janiskemper previously approved these changes Feb 29, 2024
@janiskemper janiskemper marked this pull request as ready for review February 29, 2024 12:33
Copy link
Contributor

@kranurag7 kranurag7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description field doesn't match what we have defined on types as comments.
Can you please run make generate-manifests again and push the same.

Rest, looks good to me.

Co-authored-by: janiskemper <[email protected]>

Update api/v1beta1/hetznercluster_types.go

Co-authored-by: janiskemper <[email protected]>
@kranurag7 kranurag7 merged commit b6a2dec into main Mar 20, 2024
9 checks passed
@kranurag7 kranurag7 deleted the sb/hcluster branch March 20, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Changes made in the api directory size/S Denotes a PR that changes 20-50 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants