Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SSPROD-46998] Adding agentless azure sysdig_secure_trusted_azure_app #554

Merged
merged 9 commits into from
Oct 3, 2024
Merged

[SSPROD-46998] Adding agentless azure sysdig_secure_trusted_azure_app #554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
84f0ca1
Adding agentless azure sysdig_secure_trusted_azure_app
miguelpais Sep 23, 2024
6ee6441
Small fix
miguelpais Sep 23, 2024
17761b9
Renaming app to vm_agentless
miguelpais Sep 24, 2024
8f46206
Merge branch 'master' into 46998-expose-azure-application-and-sp-on-o…
miguelpais Sep 24, 2024
fc070c8
Merge branch 'master' into 46998-expose-azure-application-and-sp-on-o…
miguelpais Sep 26, 2024
978d761
Correcting app name
miguelpais Sep 27, 2024
4bac332
Merge branch '46998-expose-azure-application-and-sp-on-onboarding' of…
miguelpais Sep 27, 2024
91efa50
Merge branch 'master' into 46998-expose-azure-application-and-sp-on-o…
miguelpais Oct 2, 2024
0f7d27f
Merge branch 'master' into 46998-expose-azure-application-and-sp-on-o…
miguelpais Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sysdig/data_source_sysdig_secure_onboarding.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ func dataSourceSysdigSecureTrustedAzureApp() *schema.Resource {
"name": {
Type: schema.TypeString,
Required: true,
ValidateFunc: validation.StringInSlice([]string{"config_posture", "onboarding", "threat_detection"}, false),
ValidateFunc: validation.StringInSlice([]string{"config_posture", "onboarding", "threat_detection", "vm_workload_scanning"}, false),
},
"tenant_id": {
Type: schema.TypeString,
Expand Down
9 changes: 9 additions & 0 deletions sysdig/data_source_sysdig_secure_onboarding_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,15 @@ func TestAccTrustedAzureAppDataSource(t *testing.T) {
resource.TestCheckResourceAttrSet("data.sysdig_secure_trusted_azure_app.threat_detection", "service_principal_id"), // uncomment to assert a non empty value
),
},
{
Config: `data "sysdig_secure_trusted_azure_app" "vm_workload_scanning" { name = "vm_workload_scanning" }`,
Check: resource.ComposeTestCheckFunc(
resource.TestCheckResourceAttr("data.sysdig_secure_trusted_azure_app.vm_workload_scanning", "name", "vm_workload_scanning"),
resource.TestCheckResourceAttrSet("data.sysdig_secure_trusted_azure_app.vm_workload_scanning", "application_id"), // uncomment to assert a non empty value
resource.TestCheckResourceAttrSet("data.sysdig_secure_trusted_azure_app.vm_workload_scanning", "tenant_id"), // uncomment to assert a non empty value
resource.TestCheckResourceAttrSet("data.sysdig_secure_trusted_azure_app.vm_workload_scanning", "service_principal_id"), // uncomment to assert a non empty value
),
},
},
})
}
Expand Down
2 changes: 1 addition & 1 deletion website/docs/d/secure_trusted_azure_app.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ data "sysdig_secure_trusted_azure_app" "onboarding" {

## Argument Reference

* `name` - (Required) Sysdig's Azure App name urrently supported applications are `config_posture`, `onboarding` and `threat_detection`
* `name` - (Required) Sysdig's Azure App name urrently supported applications are `config_posture`, `onboarding`, `threat_detection` and `vm_workload_scanning`.


## Attributes Reference
Expand Down
Loading