Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SSPROD-46998] Adding agentless azure sysdig_secure_trusted_azure_app #554

Merged

Conversation

miguelpais
Copy link
Collaborator

The sysdig azure application needs to be added to the terraform provider so that it can be used by the dependent terraform modules.

Se associated PR:
https://github.com/draios/secure-backend/pull/36116

@nkraemer-sysdig nkraemer-sysdig requested a review from a team September 25, 2024 18:00
cgeers
cgeers previously requested changes Sep 26, 2024
Copy link
Contributor

@cgeers cgeers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

acceptance tests are failing. azure_app name is wrong

… github.com:sysdiglabs/terraform-provider-sysdig into 46998-expose-azure-application-and-sp-on-onboarding
@miguelpais
Copy link
Collaborator Author

acceptance tests are failing. azure_app name is wrong

You are completely right @cgeers , thanks, updated it!

Copy link
Contributor

@cgeers cgeers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 but looks like this needs a rebase

@miguelpais miguelpais merged commit ef5380f into master Oct 3, 2024
23 checks passed
@miguelpais miguelpais deleted the 46998-expose-azure-application-and-sp-on-onboarding branch October 3, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants