Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eventhub): Org case #17

Merged
merged 29 commits into from
Dec 14, 2023
Merged

Conversation

matteopasa
Copy link
Contributor

Add organizational.tf to create diagnostic settings in every Enabled subscription of the tenant given as input.

There are 2 new input variables:

  • is_organizational
  • management_group_ids

is_organizational defaults to false and defines if the onboarding is of the full tenant or for a single subscription
management_group_ids defaults to empty list and defines the management groups to onboard. If the list is empty it defaults to the id of the root management group, that is the tenant ID.

@matteopasa matteopasa requested a review from a team as a code owner December 5, 2023 15:17
Copy link
Contributor

@ravinadhruve10 ravinadhruve10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, rest lgtm.

modules/services/event-hub-data-source/organizational.tf Outdated Show resolved Hide resolved
@matteopasa matteopasa merged commit 1d03d95 into main Dec 14, 2023
@matteopasa matteopasa deleted the jojo-pasa/event-hub-data-source-multisub branch December 14, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants