Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: android navigation bar color #1893

Merged
merged 1 commit into from
May 28, 2024
Merged

fix: android navigation bar color #1893

merged 1 commit into from
May 28, 2024

Conversation

pwltr
Copy link
Collaborator

@pwltr pwltr commented May 28, 2024

Description

Fixes android navigation bar color on non-Pixel devices

Linked Issues/Tasks

#1803

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

Screenshot / Video

Screen.Recording.2024-05-28.at.13.59.44.mov

QA Notes

Make sure navigation bar is always black on all phones independent of dark/light theme OS settings.

@pwltr pwltr force-pushed the fix/android-nav branch from 8def359 to a1afd0a Compare May 28, 2024 12:02
@pwltr pwltr requested a review from limpbrains May 28, 2024 13:06
@limpbrains
Copy link
Collaborator

Nice! 💅💅💅

@pwltr pwltr merged commit a47609a into master May 28, 2024
6 checks passed
@pwltr pwltr deleted the fix/android-nav branch May 28, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limpbrains limpbrains limpbrains approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pwltr @limpbrains