Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): android splash screen #1803

Merged
merged 1 commit into from
May 8, 2024
Merged

fix(ui): android splash screen #1803

merged 1 commit into from
May 8, 2024

Conversation

pwltr
Copy link
Collaborator

@pwltr pwltr commented May 8, 2024

Description

Fixes splash screen and app colors on Android.

Linked Issues/Tasks

Closes #1782 #1788

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

Screenshot / Video

Before:

Screen.Recording.2024-05-07.at.15.09.42.mov

After:

Screen.Recording.2024-05-08.at.13.07.05.mov

@pwltr pwltr requested a review from ovitrif May 8, 2024 11:10
@pwltr pwltr self-assigned this May 8, 2024
Copy link
Contributor

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix of everything related to splash screen and its theme colors ❤️

@pwltr pwltr merged commit 898a58a into master May 8, 2024
6 checks passed
@pwltr pwltr deleted the fix/android-splash branch May 8, 2024 12:14
@pwltr pwltr linked an issue May 8, 2024 that may be closed by this pull request
@catch-21
Copy link
Contributor

Tested on v118.
Mostly ok but for me the bottom of the screen is only black if my system is in dark mode. When in light mode it is not black, see screenshots:


Light mode:


Dark mode:


@pwltr Are we happy with that or always want it black?

@pwltr
Copy link
Collaborator Author

pwltr commented May 25, 2024

@catch-21 What's your device & Android version? Briefly tested this on my Pixel with Android 14 and the navigation bar is black for both themes.

@catch-21
Copy link
Contributor

catch-21 commented May 26, 2024

I also observe Pixel 8 (A14), Pixel 7 (A13) and Pixel 6 (A12) always show dark native buttons.

Devices affected by light/dark mode regardless of native buttons used (gesture or 3 button):

  • My Xiaomi Poco F3, Xiaomi HyperOS 1.1.0.TKHEUXM, Android 13 TKQ1.221114.001
  • Xiaomi 12 Pro(Android 12 MIUI 13.0.9)
  • Redmi Note 12 Pro (Android 12)
  • Samsung S4 (Android 14)
  • OnePlus 7T (Android 10)

@pwltr pwltr mentioned this pull request May 28, 2024
7 tasks
@catch-21
Copy link
Contributor

Verified on 8de4fa7 using my Poco F3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants