TECH-1140 Move Composite Actions into a separate #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nce release Renovate loop in Sympower Actions
…f-reference release Renovate loop in Sympower Actions" This reverts commit 87d8ab0.
…nce release Renovate loop in Sympower Actions
|
Can you clarify, what is the plan/schedule for removing them from here? |
florianbuth-sympower
approved these changes
Oct 24, 2023
I wanted to remove them already, but yesterday I added a main branch reference to the composite actions as a workaround. Meaning, some may already refer to them transitively. At the end of next week, it will be a new month, so all the teams will have received their Renovate PR. On 6th October I will go over and see, who are still the old versions or main references. I will then manually intervene in those cases. |
tonisojandu-sympower
deleted the
TECH-1140-move-composite-actions-into-different-repo
branch
|
Awesome, sounds good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to avoid self-reference release before the version commit exists and is tagged.
Self-reference would cause a Renovate loop in Sympower Actions.
Relative references are not supported yet:
actions/runner#1348
actions/runner#1684
This PR has been on the shelf since February. Comment from @nyarly from August suggests that this feature could compromise the feature set that is reserved for Enterprise users, so there is no confidence that it will be merged.
Tested the changes here:
https://github.com/sympower/msa-observability/actions/runs/6626012294
https://github.com/sympower/msa-observability/actions/runs/6626046945