Skip to content

Commit

Permalink
TECH-1140 Move Composite Actions into a separate (#50)
Browse files Browse the repository at this point in the history
This is to avoid self-reference release before the version commit exists and is tagged.
Self-reference would cause a Renovate loop in Sympower Actions.

Relative references are not supported yet:
actions/runner#1348
actions/runner#1684

This PR has been on the shelf since February.  [Comment](actions/runner#1684 (comment)) from @nyarly from August suggests that this feature could compromise the feature set that is reserved for Enterprise users, so there is no confidence that it will be merged.

Tested the changes here:
https://github.com/sympower/msa-observability/actions/runs/6626012294
https://github.com/sympower/msa-observability/actions/runs/6626046945
  • Loading branch information
tonisojandu-sympower authored Oct 24, 2023
1 parent caa9246 commit 00f890c
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 14 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/release-for-testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,27 +20,27 @@ jobs:
steps:
- id: setup-build-environment
name: "Setup build environment"
uses: sympower/sympower-actions/.github/actions/setup-build-environment@main
uses: sympower/sympower-composite-actions/setup-build-environment@v2023.10.24.10.59-6014a9a
with:
secrets: ${{ env.secrets }}
- id: format-version
name: "Format version"
uses: sympower/sympower-actions/.github/actions/format-version@main
uses: sympower/sympower-composite-actions/format-version@v2023.10.24.10.59-6014a9a
with:
style-as-release: ${{ env.IS_DEFAULT_BRANCH }}
- id: build-and-upload-docker-image
name: "Build and upload Docker Image"
uses: sympower/sympower-actions/.github/actions/build-and-upload-docker-image@main
uses: sympower/sympower-composite-actions/build-and-upload-docker-image@v2023.10.24.10.59-6014a9a
with:
version: ${{ steps.format-version.outputs.version }}
- id: upload-schema
name: "Upload schema"
uses: sympower/sympower-actions/.github/actions/upload-schema@main
uses: sympower/sympower-composite-actions/upload-schema@v2023.10.24.10.59-6014a9a
with:
secrets: ${{ env.secrets }}
version: ${{ steps.format-version.outputs.version }}
gistID: "not-used"
- id: upload-build-artifacts
name: "Upload build artifacts"
if: always()
uses: sympower/sympower-actions/.github/actions/upload-build-artifacts@main
uses: sympower/sympower-composite-actions/upload-build-artifacts@v2023.10.24.10.59-6014a9a
18 changes: 9 additions & 9 deletions .github/workflows/release-new-version.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,26 +24,26 @@ jobs:
steps:
- id: setup-build-environment
name: "Setup build environment"
uses: sympower/sympower-actions/.github/actions/setup-build-environment@main
uses: sympower/sympower-composite-actions/setup-build-environment@v2023.10.24.10.59-6014a9a
with:
secrets: ${{ env.secrets }}
- id: format-version
name: "Format version"
uses: sympower/sympower-actions/.github/actions/format-version@main
uses: sympower/sympower-composite-actions/format-version@v2023.10.24.10.59-6014a9a
with:
style-as-release: ${{ env.IS_DEFAULT_BRANCH }}
- id: run-tests
name: "Run tests"
uses: sympower/sympower-actions/.github/actions/run-tests@main
uses: sympower/sympower-composite-actions/run-tests@v2023.10.24.10.59-6014a9a
- id: code-analysis
name: "Code analysis"
uses: sympower/sympower-actions/.github/actions/code-analysis@main
uses: sympower/sympower-composite-actions/code-analysis@v2023.10.24.10.59-6014a9a
with:
secrets: ${{ env.secrets }}
- id: build-and-upload-docker-image
name: "Build and upload Docker Image"
if: env.IS_DEFAULT_BRANCH == 'true'
uses: sympower/sympower-actions/.github/actions/build-and-upload-docker-image@main
uses: sympower/sympower-composite-actions/build-and-upload-docker-image@v2023.10.24.10.59-6014a9a
with:
version: ${{ steps.format-version.outputs.version }}
- name: Update Service Version Badge
Expand All @@ -59,26 +59,26 @@ jobs:
- id: upload-schema
name: "Upload schema"
if: env.IS_DEFAULT_BRANCH == 'true'
uses: sympower/sympower-actions/.github/actions/upload-schema@main
uses: sympower/sympower-composite-actions/upload-schema@v2023.10.24.10.59-6014a9a
with:
version: ${{ steps.format-version.outputs.version }}
secrets: ${{ env.secrets }}
gistID: ${{ inputs.gistID }}
- id: upload-pacts
name: "Upload pacts"
if: env.IS_DEFAULT_BRANCH == 'true'
uses: sympower/sympower-actions/.github/actions/upload-pacts@main
uses: sympower/sympower-composite-actions/upload-pacts@v2023.10.24.10.59-6014a9a
with:
version: ${{ steps.format-version.outputs.version }}
- id: deploy-staging
name: "Deploy staging"
if: env.IS_DEFAULT_BRANCH == 'true'
uses: sympower/sympower-actions/.github/actions/deploy-staging@main
uses: sympower/sympower-composite-actions/deploy-staging@v2023.10.24.10.59-6014a9a
with:
secrets: ${{ env.secrets }}
version: ${{ steps.format-version.outputs.version }}
default-name: ${{ env.REPOSITORY_NAME }}
- id: upload-build-artifacts
name: "Upload build artifacts"
if: always()
uses: sympower/sympower-actions/.github/actions/upload-build-artifacts@main
uses: sympower/sympower-composite-actions/upload-build-artifacts@v2023.10.24.10.59-6014a9a

0 comments on commit 00f890c

Please sign in to comment.