Simplify NodeGetAttributeTypeExtension #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
reviewed
Oct 2, 2024
| @@ -51,18 +51,16 @@ public function getTypeFromMethodCall( | |||
| MethodReflection $methodReflection, | |||
| MethodCall $methodCall, | |||
| Scope $scope | |||
| ): Type { | |||
| $returnType = ParametersAcceptorSelector::selectSingle($methodReflection->getVariants())->getReturnType(); | |||
There was a problem hiding this comment.
I think to keep 1 - 1 behaviour, selectFromArgs() should be used
$returnType = ParametersAcceptorSelector::selectFromArgs($scope, $methodCall->getArgs(), $methodReflection->getVariants())->getReturnType();There was a problem hiding this comment.
when returning null PHPStan will use:
There was a problem hiding this comment.
getReturnType() return PHPStan type afaik, it maybe missing test here, but allow return null is changing behavior here
There was a problem hiding this comment.
There was a problem hiding this comment.
If I understand it correctly, it fallbacks to selectFromArgs() when null is returned.
LGTM 👍
|
Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove unnecessary use of
ParametersAcceptorSelector::selectSinglewhich is deprecated with PHPStan 2.x