Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary ParametersAcceptorSelector::selectSingle handling #9

Merged
merged 6 commits into from
Nov 11, 2024

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Oct 2, 2024

remove unnecessary use of ParametersAcceptorSelector::selectSingle which is deprecated with PHPStan 2.x

analog symplify/phpstan-rules#142

@samsonasik
Copy link
Member

@staabm is it ready for review ?

@staabm staabm marked this pull request as ready for review November 11, 2024 06:09
@staabm
Copy link
Contributor Author

staabm commented Nov 11, 2024

@samsonasik I forgot about this PR. Could you re-start CI?

@samsonasik samsonasik closed this Nov 11, 2024
@samsonasik samsonasik reopened this Nov 11, 2024
@samsonasik
Copy link
Member

sure 👍 , just close-reopen to restart it.

@samsonasik
Copy link
Member

Rector seems needs bump to ^1.x, it currently on 0.x

"rector/rector": "^0.18",

@samsonasik
Copy link
Member

@staabm
Copy link
Contributor Author

staabm commented Nov 11, 2024

done

composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
@samsonasik
Copy link
Member

Let's give it a try, thank you @staabm

@samsonasik samsonasik merged commit f88ab09 into symplify:main Nov 11, 2024
6 checks passed
@staabm staabm deleted the simple branch November 11, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants