Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ts-loader ^9.0.0, close #993 #1000

Merged
merged 1 commit into from
Jun 8, 2021
Merged

Allow ts-loader ^9.0.0, close #993 #1000

merged 1 commit into from
Jun 8, 2021

Conversation

Kocal
Copy link
Member

@Kocal Kocal commented Jun 3, 2021

Like #999, the only breaking change is that the minimum supported version of Node.js is 12.0.0,
see https://github.com/TypeStrong/ts-loader/blob/main/CHANGELOG.md#v900

EDIT: PR #1000 🤯

EDIT 2: Looks like something broke. It happens since 9.0.0 (exact version) but I don't know what happens.

EDIT 3: Added TypeScript types for .vue, and it's working fine. Not sure if it's really a BC break, I expect most of people using Vue 3 + TypeScript already using a vue-shims.d.ts file... 😕

@weaverryan
Copy link
Member

Congrats on #1000 @Kocal! And thank you as always :)

@weaverryan weaverryan merged commit 4f791f6 into symfony:main Jun 8, 2021
@Kocal Kocal deleted the GH-993 branch June 8, 2021 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants