Allow sass-loader ^12.0.0, close #996 #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only breaking change is that the minimum supported Node.js is 12.13.0, see https://github.com/webpack-contrib/sass-loader/blob/master/CHANGELOG.md#1200-2021-06-01.
Kocal
added a commit
to Kocal/webpack-encore
that referenced
this pull request
Jun 3, 2021
Like symfony#999, the only breaking change is that the minimum supported version of Node.js is 12.0.0, see https://github.com/TypeStrong/ts-loader/blob/main/CHANGELOG.md#v900
BackEndTea
approved these changes
Jun 7, 2021
|
Thanks @Kocal! |
weaverryan
added a commit
that referenced
this pull request
Jun 8, 2021
This PR was squashed before being merged into the main branch. Discussion ---------- Allow ts-loader ^9.0.0, close #993 Like #999, the only breaking change is that the minimum supported version of Node.js is 12.0.0, see https://github.com/TypeStrong/ts-loader/blob/main/CHANGELOG.md#v900 **EDIT:** PR #1000 🤯 **EDIT 2:** Looks like something broke. It happens since 9.0.0 (exact version) but I don't know what happens. **EDIT 3:** Added TypeScript types for `.vue`, and it's working fine. Not sure if it's really a BC break, I expect most of people using Vue 3 + TypeScript already using a `vue-shims.d.ts` file... 😕 Commits ------- 4587706 Allow ts-loader ^9.0.0, close #993
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only breaking change is that the minimum supported version of Node.js is 12.13.0,
see https://github.com/webpack-contrib/sass-loader/blob/master/CHANGELOG.md#1200-2021-06-01.