Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: warning and code formatting on Autocomplete #2049

Merged
merged 1 commit into from
Aug 13, 2024
Merged

fix: warning and code formatting on Autocomplete #2049

merged 1 commit into from
Aug 13, 2024

Conversation

alexislefebvre
Copy link
Contributor

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Aug 12, 2024
smnandre
smnandre approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@smnandre smnandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @alexislefebvre !

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Aug 12, 2024
@alexislefebvre alexislefebvre changed the title fix: warning on Autocomplete fix: warning and code formatting on Autocomplete Aug 12, 2024
@alexislefebvre
Copy link
Contributor Author

I fixed other issues with code formatting.

@alexislefebvre
Copy link
Contributor Author

Status: needs review

@carsonbot carsonbot added Status: Needs Review Needs to be reviewed and removed Status: Reviewed Has been reviewed by a maintainer labels Aug 12, 2024
smnandre
smnandre approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@smnandre smnandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More thanks to you :)

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Aug 12, 2024
@alexislefebvre alexislefebvre force-pushed the fix-warning-on-Autocomplete branch from ea60bdc to 226b4c7 Compare August 12, 2024 12:26
@kbond kbond force-pushed the fix-warning-on-Autocomplete branch from 226b4c7 to 58dbf49 Compare August 13, 2024 14:55
@kbond
Copy link
Member

kbond commented Aug 13, 2024

This is great, thanks Alexis!

@kbond kbond merged commit 0c24231 into symfony:2.x Aug 13, 2024
2 checks passed
@alexislefebvre alexislefebvre deleted the fix-warning-on-Autocomplete branch August 13, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smnandre smnandre smnandre approved these changes

Assignees
No one assigned
Labels
Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexislefebvre @kbond @smnandre @carsonbot