-
-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LiveComponent] Document how to use extra_options
in the Ajax-powered autocomplete
#1702
[LiveComponent] Document how to use extra_options
in the Ajax-powered autocomplete
#1702
Conversation
jakubtobiasz
commented
Apr 9, 2024
•
edited
Loading
edited
Q | A |
---|---|
Bug fix? | no |
New feature? | n/a |
Issues | requested in #1322 (comment) |
License | MIT |
a06528b
to
f57c765
Compare
Thanks @jakubtobiasz ! I'll make some minor comments / suggestions tonight, but this is very welcome ! |
@smnandre I believe there're might be some places to be improved, as I'm not the best to write docs, especially if most of them have some kind of standarization :D. So I'm open for any comments 🙌🏻. |
A more sensible point here: i'd really like to warn users those values will be "readable" from front... or are they encoded i don't remember what choice was made in the end ? |
@jakubtobiasz Thanks for this PR. In my use case, we need to overwrite the
|
@jakubtobiasz do you need some help here ? |
@smnandre being honest, this PR just fell out of my head 😅; I'll try to finalize it this ASAP. |
No hurry, and if i can help in any way please ask ;) |
f57c765
to
aab8892
Compare
@smnandre Finally I've got some time (thanks to Commerce Weavers) to finish this PR. I've left comments unresolved, so feel free to resolve them once you decide a given issue is resolved. |
I'll check later this week, but already a big thank you ! |
I have no button for this (or i don't know where to find them) 😅 But all good for me, a big big thank you :) |
Thank you Jacob. |
…efebvre) This PR was squashed before being merged into the 2.x branch. Discussion ---------- fix: warning and code formatting on Autocomplete | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | Issues | - | License | MIT Fix broken formatting on https://symfony.com/bundles/ux-autocomplete/current/index.html#passing-extra-options-to-the-ajax-powered-autocomplete Current result: > ![image](https://github.com/user-attachments/assets/cd7d7105-cf31-4bca-9374-29e8b3f49ebf) Follow-up of: - #1702 Commits ------- 58dbf49 fix: warning and code formatting on Autocomplete