Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a caution note about invoking other commands #5425

Closed
wants to merge 3 commits into from

Conversation

javiereguiluz
Copy link
Member

Q A
Doc fix? no
New docs? yes
Applies to all
Fixed tickets -

This PR finishes #4493. That's why is committed against master branch, but it should be merged in 2.3+.


Eventually, calling the ``run()`` method actually executes the command and
returns the returned code from the command (return value from command's
``execute()`` method).

.. tip::

If you want to suppress the output of the executed command, pass a :class:`Symfony\\Component\\Console\\Output\\NullOutput`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class role should be moved to its own line.

@javiereguiluz
Copy link
Member Author

All reported issues have been fixed in this pull request. Thanks.

@weaverryan
Copy link
Member

Love it! Thanks @kix for starting this and @javiereguiluz for getting us across the finish line :).

weaverryan added a commit that referenced this pull request Jul 7, 2015
…javiereguiluz)

This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes #5425).

Discussion
----------

Added a caution note about invoking other commands

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | yes
| Applies to    | all
| Fixed tickets | -

This PR finishes #4493. That's why is committed against `master` branch, but it should be merged in 2.3+.

Commits
-------

2c491be Fixed typos
b86ffb6 Removed duplication and moved a caution message
57938a5 [Console] Added a cookbook entry on invoking other commands
@weaverryan weaverryan closed this Jul 7, 2015
@kix
Copy link
Contributor

kix commented Jul 8, 2015

@weaverryan @javiereguiluz Thanks a lot for finishing this 👍

@javiereguiluz javiereguiluz deleted the pr/4493 branch May 24, 2018 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants