-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a caution note about invoking other commands #5425
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
||
Eventually, calling the ``run()`` method actually executes the command and | ||
returns the returned code from the command (return value from command's | ||
``execute()`` method). | ||
|
||
.. tip:: | ||
|
||
If you want to suppress the output of the executed command, pass a :class:`Symfony\\Component\\Console\\Output\\NullOutput` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The class
role should be moved to its own line.
All reported issues have been fixed in this pull request. Thanks. |
Love it! Thanks @kix for starting this and @javiereguiluz for getting us across the finish line :). |
weaverryan
added a commit
that referenced
this pull request
Jul 7, 2015
…javiereguiluz) This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes #5425). Discussion ---------- Added a caution note about invoking other commands | Q | A | ------------- | --- | Doc fix? | no | New docs? | yes | Applies to | all | Fixed tickets | - This PR finishes #4493. That's why is committed against `master` branch, but it should be merged in 2.3+. Commits ------- 2c491be Fixed typos b86ffb6 Removed duplication and moved a caution message 57938a5 [Console] Added a cookbook entry on invoking other commands
@weaverryan @javiereguiluz Thanks a lot for finishing this 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finishes #4493. That's why is committed against
master
branch, but it should be merged in 2.3+.