[Console] Added a cookbook entry on invoking other commands #4493
Conversation
|
|
||
| .. caution:: | ||
|
|
||
| Note that all these commands will run in the same process, and some of Symfony's |
There was a problem hiding this comment.
I like this caution but I find the phrase too long to be easily understood. Could we split it into two sentences?
There was a problem hiding this comment.
@javiereguiluz, looks better?
There was a problem hiding this comment.
Indeed it looks better to me. Thanks!
|
@kix thanks for your PR! I've found myself lost several times in the past with this issue, so this will be definitely something useful for lots of users! |
kix
force-pushed
the
add-dependent-commands-cookbook
branch
3 times, most recently
from
ffdc362 to
1d516ac
Compare
|
@javiereguiluz, the build passed, but my RST is a bit rusty. Does the PR look OK? |
| @@ -146,6 +146,40 @@ before translating contents:: | |||
| However for other services the solution might be more complex. For more details, | |||
| see :doc:`/cookbook/service_container/scopes`. | |||
|
|
|||
| Invoking other commands | |||
There was a problem hiding this comment.
Symfony docs use a special title-casing. Even if I don't fully understand it, I think that this title should be:
Invoking Other Commands
|
@kix if Travis showed no error, then the RST syntax is OK. To me this PR looks correct :) |
kix
force-pushed
the
add-dependent-commands-cookbook
branch
from
1d516ac to
f6563e6
Compare
|
We already show how to call an existing command in the components book. So I'm not sure if we really need another section for it. |
|
I don't like the duplication too, but I also agree with @javiereguiluz that the caution is pretty great. Could you please add that caution to the existing section? Also, because you proposed a new section, you probably couldn't find the already existing section. Do you have any hints/tips how to improve this, so other people will see these usefull docs? |
|
@wouterj, well, here's how I didn't find it: I looked in the cookbook, and there was the section titled |
|
@kix Can you move the caution and also replace the new example with just a reference to the already existing code? |
|
@xabbuh, @javiereguiluz, sorry I didn't have time to finish this, and thanks a lot :) |
…javiereguiluz) This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes #5425). Discussion ---------- Added a caution note about invoking other commands | Q | A | ------------- | --- | Doc fix? | no | New docs? | yes | Applies to | all | Fixed tickets | - This PR finishes #4493. That's why is committed against `master` branch, but it should be merged in 2.3+. Commits ------- 2c491be Fixed typos b86ffb6 Removed duplication and moved a caution message 57938a5 [Console] Added a cookbook entry on invoking other commands
This is a follow-up to an issue I've opened in symfony/symfony. It describes how to find and execute other commands from a Symfony
Command.