Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use single quotes for YAML strings #5935

Closed
xabbuh opened this issue Nov 30, 2015 · 0 comments
Closed

Use single quotes for YAML strings #5935

xabbuh opened this issue Nov 30, 2015 · 0 comments
Labels
actionable Clear and specific issues ready for anyone to take them. hasPR A Pull Request has already been submitted for this issue.

Comments

@xabbuh
Copy link
Member

xabbuh commented Nov 30, 2015

We should make sure to use single quotes for quoted YAML strings. The disadvantage of double quotes is that escape sequences are evaluated in them which can confuse users who are not so familiar with the YAML spec and may lead to unexpected errors/behaviour when blindly using them without properly escaping backslashes.
@xabbuh xabbuh added the actionable Clear and specific issues ready for anyone to take them. label Nov 30, 2015
This was referenced Nov 30, 2015
Merged
Merged
@snoek09 snoek09 mentioned this issue Dec 5, 2015
Closed
@wouterj wouterj added the hasPR A Pull Request has already been submitted for this issue. label Dec 5, 2015
xabbuh added a commit that referenced this issue Dec 9, 2015
@xabbuh
minor #5955 use single quotes for YAML strings (snoek09)
0a3acae 
This PR was squashed before being merged into the 2.3 branch (closes #5955).

Discussion
----------

use single quotes for YAML strings

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets | #5935

Commits
-------

81b96b6 use single quotes for YAML strings
@snoek09 snoek09 mentioned this issue Dec 9, 2015
Merged
xabbuh added a commit that referenced this issue Dec 9, 2015
@xabbuh
minor #5992 More use single quotes for YAML strings (snoek09)
abd10ca 
This PR was merged into the 2.3 branch.

Discussion
----------

More use single quotes for YAML strings

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets | #5935

Commits
-------

e9461ca use single quotes for YAML strings
@xabbuh xabbuh closed this as completed Dec 16, 2015
@snoek09 snoek09 mentioned this issue Jan 23, 2016
Merged
xabbuh added a commit that referenced this issue Jan 24, 2016
@xabbuh
minor #6180 use single quotes for YAML strings (snoek09)
e3f229d 
This PR was merged into the 2.3 branch.

Discussion
----------

use single quotes for YAML strings

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets | #5935

Commits
-------

7a95ebb use single quotes for YAML strings
@teohhanhui teohhanhui mentioned this issue Apr 4, 2018
Merged
@karser karser mentioned this issue May 23, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable Clear and specific issues ready for anyone to take them. hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wouterj @xabbuh