-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync with Symfony Standard v3.4 #224
Conversation
e318df5
to
9b958f5
Compare
@pamil Any feedback on this? |
I'm on it! :) |
Btw. can you rebase it to |
9b958f5
to
952658a
Compare
Rebased. |
The only thing that might cause issues here is "Remove bin-dir in composer.json", mostly with documentation, this PR will be good to merge after it's extracted to |
8e3c547
to
17588d3
Compare
Reverted the changes related to removing Added some more changes to fix some deprecation messages:
|
66cb998
to
76cf8b2
Compare
76cf8b2
to
e3ac7be
Compare
Thanks Teoh! 🎉 |
Some notable changes:
config/services.yml
(see Added a new services.yml file to comply with Symfony Best Practices symfony/symfony-standard#727)provider
on each firewall (see [SecurityBundle] Deprecate auto picking the first provider symfony/symfony#24378)trusted_proxies
fromconfig.yml
(see https://symfony.com/blog/fixing-the-trusted-proxies-configuration-for-symfony-3-3 and Removed the "trusted_proxies" entry from config.yml symfony/symfony-standard#1060)%kernel.project_dir%
instead of%kernel.root_dir%
(see Use single quotes and project_dir parameter symfony/symfony-standard#1065)declare(strict_types=1);