Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sentry Bundle] Make config easier to use and deploy-friendly #348

Closed
wants to merge 2 commits into from
Closed

[Sentry Bundle] Make config easier to use and deploy-friendly #348

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bda4317
Make Sentry bundle easier to use
msheakoski Apr 16, 2018
7a67f82
Remove the note for unsupported Symfony versions
msheakoski Apr 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions sentry/sentry-symfony/1.0/config/packages/prod/sentry.yaml
View file
Open in desktop

This file was deleted.

9 changes: 9 additions & 0 deletions sentry/sentry-symfony/1.0/config/packages/sentry.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,13 @@
parameters:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"parameters" should be defined via the "container" configurator instead

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not very helpful. I have no idea what it means. Maybe it would be great to include a link to the docs describing this? /cc @fabpot

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"parameters" should be defined via the "container" configurator instead

# Add a fallback SENTRY_DSN if the env var is not set. This allows you to
# run cache:warmup even if your environment variables are not available yet.
# You should not need to change this value.
env(SENTRY_DSN): ''

sentry:
# Remove the `resolve:` operator if you are using Symfony 3.3
dsn: '%env(resolve:SENTRY_DSN)%'

options:
curl_method: async

Expand Down