[Sentry Bundle] Make config easier to use and deploy-friendly

[msheakoski]

I made a few changes to the config to remove some frustrations that I encountered while developing and deploying. They were inspired by the Doctrine recipe:

• Set a default value for the SENTRY_DSN env var to prevent errors during deployment when running commands like cache:warmup
• Merge config/packages/prod/sentry.yaml into config/packages/sentry.yaml for simplicity. I do not see a reason for separating them by default

Sentry will be enabled in any environment where a non-blank SENTRY_DSN env var is provided. Not setting the var or having it set to an empty string will disable Sentry error handling

@ruudk pinging you since you are the maintainer

Q	A
License	MIT

[ghost]

Pull request does not pass validation.

[ghost]

"parameters" should be defined via the "container" configurator instead

[ruudk]

This is not very helpful. I have no idea what it means. Maybe it would be great to include a link to the docs describing this? /cc @fabpot

[ruudk]

Set a default value for the SENTRY_DSN env var to prevent errors during deployment when running commands like cache:warmup

What issues do you get?

You just need to add the SENTRY_DSN= to your .env file.

When you install this recipe, it will automatically do this for you.

[msheakoski]

You just need to add the SENTRY_DSN= to your .env file.

Sure, it works fine in the "dev" environment, but when you want to deploy your app and have steps in your deployment script that warm up the cache you receive Environment variable not found: "SENTRY_DSN" errors. I am simply copying the pattern used for the Doctrine recipe since they encountered and solved the same issue.

[msheakoski]

@ruudk please see symfony/recipes#258 for their discussion on the same issue that the Sentry bundle faces.

[ghost]

Pull request does not pass validation.

[ghost]

"parameters" should be defined via the "container" configurator instead

[Nyholm]

Thank you for this PR.

I do not agree with the reasons you specify here. I would very much like that the deployment process fails if I do not have all my environment variables set. This issue as you refer to is not specific to Sentry but it is how environment variables work.

Im currently 👎

[ruudk]

@Nyholm I agree,

[Nyholm]

@msheakoski, what do you think?

[msheakoski]

I would very much like that the deployment process fails if I do not have all my environment variables set.

@Nyholm @ruudk this is a good point. I will close this PR since the current behavior seems to be the best approach.