add SonataBlockBundle #235

kricha · 2018-01-05T20:43:40Z

Q	A
License	MIT

ghost

Pull request passes validation.

ghost

Pull request passes validation.

ghost

Pull request passes validation.

covex-nn · 2018-01-05T21:10:28Z

sonata-project/block-bundle/3.9/config/packages/sonata_block.yaml

+    templating:
+        engines: ['twig']
+sonata_block:
+    default_contexts: [cms]


cms context is never used anywhere, and it was renamed to sonata_page_bundle for SonataPageBundle (see https://stackoverflow.com/questions/22798670/what-is-context-in-sonata-block-bundle). So, i think cms should be removed from default_contexts here.

OskarStark · 2018-01-05T21:23:10Z

//cc @greg0ire

ghost

Pull request passes validation.

ghost

Pull request passes validation.

ghost

Pull request passes validation.

ghost

Pull request passes validation.

ghost

Pull request does not pass validation.

ghost · 2018-01-06T08:57:28Z

sonata-project/block-bundle/3.9/config/packages/sonata_block.yaml

@@ -0,0 +1 @@
+sonata_block: {}


"sonata_block" should be removed as it is empty

ghost

Pull request does not pass validation.

ghost · 2018-01-06T08:57:48Z

sonata-project/block-bundle/3.9/config/packages/sonata_block.yaml

@@ -0,0 +1 @@
+sonata_block: {}


"sonata_block" should be removed as it is empty

ghost

Pull request passes validation.

ghost

Pull request passes validation.

ghost

Pull request passes validation.

kricha · 2018-01-07T14:51:08Z

@OskarStark @greg0ire so, we need to add TwigBundle to SonataBlockBundle?

greg0ire · 2018-01-07T14:56:28Z

It probably should, since we are referencing it: https://github.com/sonata-project/SonataBlockBundle/search?utf8=%E2%9C%93&q=twigbundle&type=

kricha · 2018-01-07T14:59:08Z

@greg0ire ok, i'll create pull-request

OskarStark · 2018-01-08T09:41:25Z

We released 3.92 of block-bundle

ghost

Pull request passes validation.

ghost

Pull request does not pass validation.

kricha · 2018-01-08T09:52:59Z

i think this will work after merging this #151

ghost

Pull request passes validation.

ghost

Pull request does not pass validation.

ghost

Pull request passes validation.

covex-nn · 2018-01-13T23:28:34Z

@aLkRicha please move config/packages/sonata_projects/sonata_block.yaml to config/packages directory. Travis will not be green, because of templating service. But there will not be a error message about default_contexts.

OskarStark · 2018-01-16T06:41:32Z

I asked for a BlockBundle release @aLkRicha @covex-nn

kricha · 2018-01-16T07:24:17Z

@OskarStark @covex-nn i'm waiting this PR sonata-project/SonataBlockBundle#457

covex-nn · 2018-01-16T12:33:20Z

@OskarStark @aLkRicha since 3.10.0 there is no need to create a recipe for BlockBundle:

Recipe is used only for new projects, it is used for initial configuration only
Projects with BlockBundle < v3.10 are already configured
New projects will use BlockBundle >= 3.10.0 with it's default configuration. See it for yourself:
```
composer create-project symfony/skeleton .
composer config extra.symfony.allow-contrib true
composer require sonata-project/block-bundle
```
There you will see error about templating service The service "sonata.block.service.container" has a dependency on a non-existent service "templating". And this dependency must be removed.

But i can be wrong: may be we should create recipe for 3.9.*, what do you think?

covex-nn · 2018-01-23T15:47:16Z

@OskarStark @aLkRicha sonata-project/SonataBlockBundle#457 is merged and released with 3.11.0, but i'm still not sure if we need a recipe for BlockBundle

Nyholm · 2018-01-28T09:26:27Z

So, should I close this?

jordisala1991 · 2018-02-05T14:16:01Z

Default context is no longer required, so maybe we don't need this recipe

jordisala1991 · 2018-02-12T19:19:21Z

And this one can be closed, it is not needed

ghost deployed to staging January 5, 2018 20:43 View deployment

ghost approved these changes Jan 5, 2018

View reviewed changes

ghost deployed to staging January 5, 2018 20:52 View deployment

ghost approved these changes Jan 5, 2018

View reviewed changes

kricha force-pushed the sonata-block branch from 8d7315d to 4cbec47 Compare January 5, 2018 20:52

ghost deployed to staging January 5, 2018 20:52 View deployment

ghost approved these changes Jan 5, 2018

View reviewed changes

covex-nn reviewed Jan 5, 2018

View reviewed changes

OskarStark mentioned this pull request Jan 6, 2018

add SonataAdminBundle #234

Closed

ghost deployed to staging January 6, 2018 08:38 View deployment

ghost approved these changes Jan 6, 2018

View reviewed changes

kricha force-pushed the sonata-block branch from 9aec257 to dcd0bc4 Compare January 6, 2018 08:39

ghost deployed to staging January 6, 2018 08:39 View deployment

ghost approved these changes Jan 6, 2018

View reviewed changes

ghost deployed to staging January 6, 2018 08:40 View deployment

ghost approved these changes Jan 6, 2018

View reviewed changes

kricha force-pushed the sonata-block branch from 85aa3cb to 7da6388 Compare January 6, 2018 08:40

ghost deployed to staging January 6, 2018 08:40 View deployment

ghost approved these changes Jan 6, 2018

View reviewed changes

ghost suggested changes Jan 6, 2018

View reviewed changes

kricha force-pushed the sonata-block branch from d551ddd to abeb8f1 Compare January 6, 2018 08:57

ghost suggested changes Jan 6, 2018

View reviewed changes

ghost deployed to staging January 6, 2018 08:59 View deployment

ghost approved these changes Jan 6, 2018

View reviewed changes

kricha force-pushed the sonata-block branch from 3307a72 to 10076bc Compare January 6, 2018 08:59

ghost deployed to staging January 6, 2018 08:59 View deployment

ghost approved these changes Jan 6, 2018

View reviewed changes

ghost deployed to staging January 6, 2018 09:01 View deployment

ghost approved these changes Jan 6, 2018

View reviewed changes

kricha mentioned this pull request Jan 7, 2018

Pull Requests for the possibility of creating a symfony recipe sonata-project/SonataBlockBundle#462

Merged

kricha force-pushed the sonata-block branch from a49f49a to 3b2692e Compare January 8, 2018 09:48

ghost deployed to staging January 8, 2018 09:48 View deployment

ghost approved these changes Jan 8, 2018

View reviewed changes

kricha force-pushed the sonata-block branch from 3b2692e to 7377ba6 Compare January 8, 2018 09:50

ghost suggested changes Jan 8, 2018

View reviewed changes

kricha force-pushed the sonata-block branch from 7377ba6 to ea15190 Compare January 8, 2018 10:04

ghost deployed to staging January 8, 2018 10:04 View deployment

ghost approved these changes Jan 8, 2018

View reviewed changes

kricha mentioned this pull request Jan 8, 2018

add one more dependency in composer for creating symfony-recipe sonata-project/SonataBlockBundle#463

Closed

add SonataBlockBundle

29ee6cd

ghost suggested changes Jan 10, 2018

View reviewed changes

kricha force-pushed the sonata-block branch from 4342456 to 29ee6cd Compare January 10, 2018 08:07

ghost deployed to staging January 10, 2018 08:07 View deployment

ghost approved these changes Jan 10, 2018

View reviewed changes

covex-nn mentioned this pull request Jan 13, 2018

Fix sonata-project/core-bundle config #249

Merged

fabpot closed this Feb 13, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add SonataBlockBundle #235

add SonataBlockBundle #235

kricha commented Jan 5, 2018

ghost left a comment

ghost left a comment

ghost left a comment

covex-nn Jan 5, 2018

OskarStark commented Jan 5, 2018

ghost left a comment

ghost left a comment

ghost left a comment

ghost left a comment

ghost left a comment

ghost Jan 6, 2018

ghost left a comment

ghost Jan 6, 2018

ghost left a comment

ghost left a comment

ghost left a comment

kricha commented Jan 7, 2018

greg0ire commented Jan 7, 2018

kricha commented Jan 7, 2018

OskarStark commented Jan 8, 2018 •

edited

Loading

ghost left a comment

ghost left a comment

kricha commented Jan 8, 2018

ghost left a comment

ghost left a comment

ghost left a comment

covex-nn commented Jan 13, 2018 •

edited

Loading

OskarStark commented Jan 16, 2018

kricha commented Jan 16, 2018

covex-nn commented Jan 16, 2018

covex-nn commented Jan 23, 2018

Nyholm commented Jan 28, 2018

jordisala1991 commented Feb 5, 2018 •

edited

Loading

jordisala1991 commented Feb 12, 2018

		@@ -0,0 +1 @@
		sonata_block: {}

		@@ -0,0 +1 @@
		sonata_block: {}

add SonataBlockBundle #235

add SonataBlockBundle #235

Conversation

kricha commented Jan 5, 2018

ghost left a comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

covex-nn Jan 5, 2018

Choose a reason for hiding this comment

OskarStark commented Jan 5, 2018

ghost left a comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

ghost Jan 6, 2018

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

ghost Jan 6, 2018

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

kricha commented Jan 7, 2018

greg0ire commented Jan 7, 2018

kricha commented Jan 7, 2018

OskarStark commented Jan 8, 2018 • edited Loading

ghost left a comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

kricha commented Jan 8, 2018

ghost left a comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

covex-nn commented Jan 13, 2018 • edited Loading

OskarStark commented Jan 16, 2018

kricha commented Jan 16, 2018

covex-nn commented Jan 16, 2018

covex-nn commented Jan 23, 2018

Nyholm commented Jan 28, 2018

jordisala1991 commented Feb 5, 2018 • edited Loading

jordisala1991 commented Feb 12, 2018

OskarStark commented Jan 8, 2018 •

edited

Loading

covex-nn commented Jan 13, 2018 •

edited

Loading

jordisala1991 commented Feb 5, 2018 •

edited

Loading