-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add one more dependency in composer for creating symfony-recipe #463
Conversation
What about #457 ? |
@OskarStark aha.. ok, i could close this one. |
It could get merged independently from the other PR... |
@OskarStark if all is ok, you can merge this one 😅 |
Please explain why did you added this dependency to composer on the changelog |
@jordisala1991 because without this i'm getting this error:
|
Yep, I get it, but you need to explain it on the changelog :) End users should know what does change with your PR |
@jordisala1991 is it ok now? |
This PR will not help to create recipe. Because, you cannot configure framework:
templating:
engines: ["twig"] So, even if you will add |
@covex-nn yes, but we can add something like that:
|
@aLkRicha these lines will not be accepted with comments or without them. See discussion about session symfony/recipes#262. Session can be enabled only with this config: framework:
session: ~ ... but they say, that we cannot do this. If session cannot be activated in recipe config, then templating cannot be activated too. Also, see stof's comment about templating: symfony/flex#247 (comment). He said, that "they precisely want to discourage the usage of the Templating wrapper in Flex projects". |
@covex-nn so there is no way to create sonataadmin recipe because of session? |
See symfony/recipes#333 - session will be activated by default after merge. Right now there will be error about session service |
We need #457 instead of this. |
I am targeting this branch, because we are creating recipe for 3.x version.
Fix for symfony/recipes-contrib#235
Changelog