Support Symfony 3 #347
Support Symfony 3 #347
Conversation
…Sonata dependencies, use parentDocument in Admin classes, update route_basepaths in tests
| @@ -3,4 +3,4 @@ cmf_routing: | |||
| persistence: | |||
| phpcr: | |||
| enabled: true | |||
| route_basepath: /test/routing | |||
| route_basepaths: /test/routing | |||
There was a problem hiding this comment.
should this be an [ 'array' ] ? I know that we probably support scalars, but I think its better to treat a plural as a plural.
There was a problem hiding this comment.
not sure. it does not cost us much to convert string to array here for when you have only one path. @wouterj what do you think is better DX? do we create confusion by allowing single value or is it convenient?
|
hm, why is travis-ci not looking at this? if this is all it takes, i wonder if we could support symfony 3 with a routing bundle 1.x . should we branch alias to 1.5 and aim to release an 1.5.0 as soon as symfony 3 support is solid? |
|
i mean: i don't see any BC breaks in this PR, this is what made me think we could have an 1.x release of this. |
|
Hmm, indeed, @dbu. However, there is a problem: None of the dev (optional) dependencies support Symfony 3. This means that we can't run the functional and webtests with Symfony 3. It also means that people can't use the admin integration, etc. If no other CMF bundle supports Symfony 3, does it make sense to support Symfony 3 in this bundle? |
|
not sure but i think some people use this without other cmf bundles and
without sonata, so it would be useful to them.
but if we can't run the functional tests, i am not confident to call
things supported. lets be pragmatic and have this go into a 2.0 version
together with the rest then.
|
|
Please note that for Symfony 3 support, people can require |
|
can we fix styleci too? |
|
I now got all tests working on Symfony 3 locally. This requires sonata-project/SonataAdminBundle#3709 and sonata-project/SonataDoctrinePhpcrAdminBundle#367 to be merged first. |
|
sonata-project/SonataDoctrinePhpcrAdminBundle#367 is merged, is this now ready? i restarted the PR build. |
|
I'll try to merge most of the open Sf3 PR this evening |
wouterj
force-pushed
the
support-sf3
branch
2 times, most recently
from
2ded1ed to
11ddf01
Compare
wouterj
force-pushed
the
support-sf3
branch
2 times, most recently
from
560fc0f to
ccbda26
Compare
|
It took a bit longer, but the road to Symfony 3 support is now officially open :) |
|
It took a bit longer, but the road to Symfony 3 support is now
officially open :)
woohoo, thanks a lot for your efforts wouter!
|
|
@dbu will there be progess for 1.x series? in the future? |
|
we try to get the 2.0 versions out of the door. at that point we will not spend time on 1.x anymore, we don't have the resources. as far as i can see, 2.0 will however still support symfony 2.8 |
Created a new branch, so I don't have to rebase a branch that's used by people already.