This repository has been archived by the owner on Jul 22, 2022. It is now read-only.
Fix even more Symfony 3 support (and some other bugs) #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -62,7 +66,7 @@ public function guessType($class, $property, ModelManagerInterface $modelManager | |||
| $options['operator_type'] = 'sonata_type_boolean'; | |||
| $options['operator_options'] = array(); | |||
|
|
|||
| $options['field_type'] = 'document'; | |||
| $options['field_type'] = DocumentType::class; | |||
There was a problem hiding this comment.
document never existed afaik. I guess phpcr_document was meant to be used (so in fact, nobody ever used this filter)
This was referenced Apr 9, 2016
|
cool, great job wouter. yeah, lets drop php < 5.5 according to travis, you missed one case of the TextType. |
|
Fixed tests and CS. Turns out PHP <5.5 was already dropped. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests still have to be updated. This was the minimum required things to get at least something working. My guess is that this bundle needs a lot more fixes before working 100% on Symfony 3.
Can we bump to PHP 5.5 support, or do I still need to put the FQCN in strings instead of using
::class?