Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to DoctrineCacheBundle #241

Merged
merged 1 commit into from
Mar 24, 2014
Merged

switch to DoctrineCacheBundle #241

merged 1 commit into from
Mar 24, 2014

Conversation

lsmith77
Copy link
Member

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR missing

see also doctrine/DoctrineCacheBundle#13

settings in ``app/config/config.yml``.
To enable the meta data and node cache to improve performance first enable ``DoctrineCacheBundle``
in ``app/AppKernel.php``. Finally uncomment the ``caches`` settings in the `phpcr.yml` as well as
the ``doctrine_cache`` settings in ``app/config/config.yml``.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we not just activate this by default? or does it only work with doctrine dbal, not with jackalope-jackrabbit?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would not cause issues to activate it by default. however i am not sure if we really want to enable this by default. imho its good for users to see what the caching does. though we could of course enable it and leave a note about disabling it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets do that then, yes. the sandbox is in itself not a tutorial but a thing that should work and show how to do things. or does the caching interfere with developing? a guide how to see what makes your app faster or not should be in the symfony-cmf-docs rather.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@dbu
Copy link
Member

dbu commented Mar 24, 2014

cool. do we wait for the bundle to be tagged stable or merge already?

@lsmith77
Copy link
Member Author

i think we can merge now .. i am 100% certain that there will be a stable release in time for us going stable

dbu added a commit that referenced this pull request Mar 24, 2014
@dbu dbu merged commit 484cb71 into master Mar 24, 2014
@dbu dbu deleted the doctrine-cache-bundle branch March 24, 2014 12:52
@dbu
Copy link
Member

dbu commented Mar 24, 2014

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants