Skip to content
This repository has been archived by the owner on Oct 29, 2020. It is now read-only.

1.0 release #13

Closed
FabioBatSilva opened this issue Mar 1, 2014 · 13 comments
Closed

1.0 release #13

FabioBatSilva opened this issue Mar 1, 2014 · 13 comments

Comments

@FabioBatSilva
Copy link
Member

@doctrine/team-doctrine2
@doctrine/team-symfony-integration
Any thing you guys what to add before we tag 1.0 release ?

@lsmith77
Copy link
Member

lsmith77 commented Mar 1, 2014

trying to use this Bundle as a LiipDoctrineBundle replacement and I am having some issues trying to figure out how to configure the Bundle while using dev-master.

I tried:

doctrine_cache:
    providers:
        meta:
            type: file_system
            aliases:
                liip_doctrine_cache.ns.meta
        nodes:
            type: file_system
            aliases:
                liip_doctrine_cache.ns.nodes

leads to:

Notice: Undefined index: file_system in /Users/lsmith/htdocs/cmf-sandbox/vendor/doctrine/doctrine-cache-bundle/Doctrine/Bundle/DoctrineCacheBundle/DependencyInjection/Definition/FileSystemDefinition.php on line 29

I am not really sure how the structure in the FileSystemDefinition.php file should be created ..

@lsmith77
Copy link
Member

lsmith77 commented Mar 1, 2014

ok .. nevermind .. send a PR to fix the issue. seems to work now .. so with this it should be easy for LiipDoctrineCacheBundle users to migrate, so all good from my side once the PR is merged.

@guilhermeblanco
Copy link
Member

I still want to increase coverage of AclCache before we do it. Right now it's barely tested (only the success scenario is tested).
This is the reason why the Symfony's implementation is broken and none knew about it. I'll work on some during this weekend/beginning next week and let's release it. It would also be perfectly nice to have DoctrineBundle released with the next alpha version as a result of all changes we made lately.

@guilhermeblanco
Copy link
Member

Committed what I consider a reasonable state of tests... we are ok to release from my pov.

Commit reference: 898569c

@stof
Copy link
Member

stof commented Mar 3, 2014

Before releasing, I suggest enabling Travis testing on PHP 5.6 (the alpha1 is available on Travis currently) and HHVM

And the composer dependencies should be fixed to require doctrine/inflector explicitly as it is used (currently, it works only because the bundle requires the Doctrine Bridge, which requires Doctrine Common, which itself requires Doctrine Inflector for BC reasons)

@FabioBatSilva
Copy link
Member Author

Build matrix and dependencies are updated 6fc6ff7

@guilhermeblanco
Copy link
Member

@FabioBatSilva whenever you feel comfortable, release 1.0.0. =D

@FabioBatSilva
Copy link
Member Author

\o/ --- 1.0 beta1 released --- \o/

@lsmith77
Copy link
Member

anything holding back a first stable release?

@guilhermeblanco
Copy link
Member

@lsmith77 we're evaluating how this behaves in production for a couple of days before we officially tag 1.0.0. Should be ok to go in a few days.

@lsmith77
Copy link
Member

ping

@FabioBatSilva
Copy link
Member Author

Released : v1.0.0

@lsmith77
Copy link
Member

thx!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants