Update doctrine dependencies to newest version #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
~~Is the doctrine-bundle: ~1.3@dev still needed? ~~It seems all occurrences of theDoctrineOrmMappingPass are gone, maybe a downgrade to ~1.2 is possible?~~ [Uff, typo while searching the code, it's named @Sylius, exposed from #1141, #931 becomes actual, only the bundles which uses the mappings pass should declare the ~1.3 dependency and not the resource-bundle as in #870 changed. This prevents using the resource-bundle standalone and with a stable doctrine-bundle version. |
|
ping @pjedrzejewski what do you think? |
pjedrzejewski
pushed a commit
that referenced
this pull request
Mar 4, 2014
Update doctrine dependencies to newest version
|
Sounds right, thank you Patrik! I'll have a look at the other issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update doctrine dependencies to newest version and add cache-bundle at dev. Since doctrine/DoctrineBundle@e37301f7 it depends on the new
doctrine/doctrine-cache-bundle: ~1.0which is currently not available as stable version.Without this change composer update would degrade to
doctrine/doctrine-bundle: 1.3.0-beta1which is known as broken.References doctrine/DoctrineBundle#276 and doctrine/DoctrineCacheBundle#13 (after releasing this fix can be removed ^^)