Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(styles, documentation): styles update text input #3229

Merged
merged 13 commits into from
Jul 23, 2024

Conversation

davidritter-dotcom
Copy link
Contributor

@davidritter-dotcom davidritter-dotcom commented Jul 10, 2024

Waiting for the following PR to be merged because the icon in the validation message gets added in that PR and the icon inside the input field gets deleted in this one.

@davidritter-dotcom davidritter-dotcom requested a review from a team as a code owner July 10, 2024 08:19
@davidritter-dotcom davidritter-dotcom linked an issue Jul 10, 2024 that may be closed by this pull request
Copy link

changeset-bot bot commented Jul 10, 2024

🦋 Changeset detected

Latest commit: ce4b306

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@swisspost/design-system-documentation Patch
@swisspost/design-system-styles Patch
@swisspost/design-system-components-angular-workspace Patch
@swisspost/design-system-components Patch
@swisspost/design-system-demo Patch
@swisspost/internet-header Patch
@swisspost/design-system-intranet-header-workspace Patch
@swisspost/design-system-nextjs-integration Patch
@swisspost/design-system-styles-primeng-workspace Patch
@swisspost/design-system-intranet-header Patch
@swisspost/design-system-styles-primeng Patch
@swisspost/design-system-components-react Patch
@swisspost/design-system-components-angular Patch
@swisspost/design-system-intranet-header-showcase Patch
@swisspost/design-system-icons Patch
@swisspost/design-system-migrations Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Jul 10, 2024

Related Previews

@davidritter-dotcom davidritter-dotcom added the 🚂 PR train PR which follows another one. label Jul 10, 2024
@gfellerph
Copy link
Member

@davidritter-dotcom, blocking PR is merged.

@gfellerph gfellerph removed the 🚂 PR train PR which follows another one. label Jul 18, 2024
Copy link
Contributor

@oliverschuerch oliverschuerch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The textarea element has still a icon when valid.
    image
  • The select element now has both icons, the one in the background and the one in the error message. This occurs in both states, valid and invalid.
    image

.changeset/gold-rabbits-train.md Outdated Show resolved Hide resolved
@gfellerph gfellerph requested a review from oliverschuerch July 22, 2024 14:49
@gfellerph gfellerph added the v8 label Jul 22, 2024
Copy link

@oliverschuerch oliverschuerch merged commit 384b11d into main Jul 23, 2024
10 checks passed
@oliverschuerch oliverschuerch deleted the 2527-styles-update-text-input branch July 23, 2024 06:38
alizedebray pushed a commit that referenced this pull request Jul 23, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @swisspost/[email protected]

### Major Changes

- Upgraded to Angular 18 (by [@gfellerph](https://github.com/gfellerph)
with [#3243](#3243))

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Major Changes

- Upgraded to Angular 18 (by [@gfellerph](https://github.com/gfellerph)
with [#3243](#3243))

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Major Changes

- Upgraded to Angular 18 (by [@gfellerph](https://github.com/gfellerph)
with [#3243](#3243))

### Patch Changes

- Removed the icon from inside form-controls (`input`, `select`,
`textarea`). (by
[@davidritter-dotcom](https://github.com/davidritter-dotcom) with
[#3229](#3229))

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]



## @swisspost/[email protected]



## @swisspost/[email protected]

### Major Changes

- Upgraded to Angular 18 (by [@gfellerph](https://github.com/gfellerph)
with [#3243](#3243))

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Minor Changes

- Added `Components/Notifications` tokens. Added semantic tokens
(`mode/light`, `mode/dark`, `device/desktop`, `device/tablet`,
`device/mobile`, `channel/idk`, `channel/edk` and `theme/post`), to link
`core` tokens to the `Components/Notifications` tokens. (by
[@oliverschuerch](https://github.com/oliverschuerch) with
[#3262](#3262))

- Added core tokens for `color`, `dimensions`, `font-weight`,
`font-size`, `line-height`, `letter-spacing`, `font-family`, `elevation`
and `border`. (by [@oliverschuerch](https://github.com/oliverschuerch)
with [#3262](#3262))

- Added `Components/Interactives` tokens. Added semantic tokens
(`mode/light`, `mode/dark`, `device/desktop`, `device/tablet`,
`device/mobile`, `channel/idk`, `channel/edk` and `theme/post`), to link
`core` tokens to the `Components/Interactives` tokens. (by
[@oliverschuerch](https://github.com/oliverschuerch) with
[#3262](#3262))

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

- Removed the icon from inside form-controls (`input`, `select`,
`textarea`). (by
[@davidritter-dotcom](https://github.com/davidritter-dotcom) with
[#3229](#3229))

- Added a migration section that explains how to go from 7 to 8. (by
[@gfellerph](https://github.com/gfellerph) with
[#3243](#3243))

-   Updated dependencies:
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Styles: Update text input
4 participants