Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Styles: Update text input #2527

Closed
6 of 7 tasks
gfellerph opened this issue Jan 22, 2024 · 3 comments · Fixed by #3229
Closed
6 of 7 tasks

Styles: Update text input #2527

gfellerph opened this issue Jan 22, 2024 · 3 comments · Fixed by #3229
Assignees
@davidritter-dotcom
Labels
📦 styles Related to the @swisspost/design-system-styles package
Milestone
Design - Implemen...

Comments

@gfellerph
Copy link
Member

gfellerph commented Jan 22, 2024 •
edited by davidritter-dotcom
Loading

Design: https://www.figma.com/file/xZ0IW0MJO0vnFicmrHiKaY/Components-Post?type=design&node-id=7775%3A33876&mode=design&t=VnF7Nfba4zszs6Kt-1

Floating label animation: An empty floating label text input shows the placeholder text, if it is specified. This placeholder appears as soon as the label begins to float to the top. As the label is above the placeholder, it covers the placeholder during the floating to the top. This creates a visually unpleasing effect and looks broken. I think the effect can be reduced by animating the opacity on the placeholder with the same duration as the label floating animation (implement and verify with Design).

Tasks
Preview Give feedback
  1. Update text input styles #1835
    2 of 2
    pibs request 📦 styles
    imagoiq
@gfellerph gfellerph added 📦 styles Related to the @swisspost/design-system-styles package 💭 draft Issue is not ready for development labels Jan 22, 2024
@gfellerph gfellerph mentioned this issue Jan 22, 2024
Closed
4 tasks
@imagoiq
Copy link
Contributor

imagoiq commented Jan 24, 2024

About the floating variant with small size, there is the following ticket + a PR: #1835
#2396

@gfellerph gfellerph removed the 💭 draft Issue is not ready for development label Jan 24, 2024
@gfellerph gfellerph mentioned this issue Jan 24, 2024
Closed
@davidritter-dotcom davidritter-dotcom self-assigned this Mar 20, 2024
@oliverschuerch oliverschuerch moved this from Ready for work (backlog) to Ready for development in Design System Production Board Apr 23, 2024
@davidritter-dotcom
Copy link
Contributor

Waiting for #2857 to be merged.

@davidritter-dotcom davidritter-dotcom removed their assignment Apr 24, 2024
@davidritter-dotcom davidritter-dotcom self-assigned this Jun 5, 2024
@davidritter-dotcom davidritter-dotcom moved this from 💎 Ready for development to 🤬 Dev in code review in Design System Production Board Jun 6, 2024
@davidritter-dotcom davidritter-dotcom moved this from 🤬 Dev in code review to 🕹️ Dev in progress in Design System Production Board Jun 6, 2024
@davidritter-dotcom
Copy link
Contributor

@davidritter-dotcom davidritter-dotcom mentioned this issue Jul 4, 2024
Merged
@davidritter-dotcom davidritter-dotcom linked a pull request Jul 10, 2024 that will close this issue
feat(styles, documentation): styles update text input #3229
Merged
1 task
@davidritter-dotcom davidritter-dotcom moved this from 🕹️ Coding in progress to 🤬 Dev in review in Design System Production Board Jul 10, 2024
@github-project-automation github-project-automation bot moved this from 🤬 Dev in review to 🚀 Done in Design System Production Board Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidritter-dotcom davidritter-dotcom

Labels
📦 styles Related to the @swisspost/design-system-styles package
Projects
Design System Production Board
Archived in project
Milestone
Design - Implementation Sync
Development

Successfully merging a pull request may close this issue.

feat(styles, documentation): styles update text input swisspost/design-system
3 participants
@gfellerph @imagoiq @davidritter-dotcom