Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styles): add focus ring to checkbox and radio button groups #3063

Conversation

alizedebray
Copy link
Contributor

No description provided.

@alizedebray alizedebray requested a review from a team as a code owner May 3, 2024 15:11
@alizedebray alizedebray requested a review from oliverschuerch May 3, 2024 15:11
@alizedebray alizedebray linked an issue May 3, 2024 that may be closed by this pull request
Copy link

changeset-bot bot commented May 3, 2024

🦋 Changeset detected

Latest commit: 6dde8d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
Name Type
@swisspost/design-system-styles Patch
@swisspost/design-system-components-angular-workspace Patch
@swisspost/design-system-components Patch
@swisspost/design-system-demo Patch
@swisspost/design-system-documentation Patch
@swisspost/internet-header Patch
@swisspost/design-system-intranet-header-workspace Patch
@swisspost/design-system-nextjs-integration Patch
@swisspost/design-system-intranet-header Patch
@swisspost/design-system-components-react Patch
@swisspost/design-system-components-angular Patch
@swisspost/design-system-intranet-header-showcase Patch
@swisspost/design-system-icons Patch
@swisspost/design-system-migrations Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented May 3, 2024

Related Previews

Copy link

sonarqubecloud bot commented May 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@alizedebray alizedebray merged commit 40d4d04 into main May 13, 2024
9 checks passed
@alizedebray alizedebray deleted the 3025-button-group-focus-invisible-if-radio-buttons-or-checkboxes branch May 13, 2024 11:15
alizedebray added a commit that referenced this pull request May 23, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @swisspost/[email protected]

### Minor Changes

- Added a `heading-level` property on the `post-accordion` component to
set the heading level of all `post-accordion-item` children at once. (by
[@alizedebray](https://github.com/alizedebray) with
[#3067](#3067))

### Patch Changes

- Merged the card-control, checkbox-card and radio button card docs
pages and updated the choice-card-control styles. (by
[@oliverschuerch](https://github.com/oliverschuerch) with
[#2847](#2847))

- Fixed high-contrast-mode for card-control component. (by
[@oliverschuerch](https://github.com/oliverschuerch) with
[#2995](#2995))

- Fixed the `post-accordion-item` chevron no longer rotating. (by
[@alizedebray](https://github.com/alizedebray) with
[#3081](#3081))

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Minor Changes

- Added a `heading-level` property on the `post-accordion` component to
set the heading level of all `post-accordion-item` children at once. (by
[@alizedebray](https://github.com/alizedebray) with
[#3067](#3067))

## @swisspost/[email protected]

### Minor Changes

- Added icon number 2585. (by
[@swisspost-bot](https://github.com/swisspost-bot) with
[#3018](#3018))

- Added icons number 2586, 2587 and 2588. (by
[@swisspost-bot](https://github.com/swisspost-bot) with
[#3077](#3077))

## @swisspost/[email protected]

### Minor Changes

- Added the option for a Button animation to the left. (by
[@davidritter-dotcom](https://github.com/davidritter-dotcom) with
[#2865](#2865))

### Patch Changes

- Fixed missing chevron in valid and invalid select entries. (by
[@alizedebray](https://github.com/alizedebray) with
[#3075](#3075))

- Updated popover styles. - Removed popover `min-width` and updated
`max-width`.

    -   Simplyfied popover arrow size definition.
- Removed `:focus` selector fom `.text-auto` utility class (by
[@imagoiq](https://github.com/imagoiq) with
[#2926](#2926))

- Merged the card-control, checkbox-card and radio button card docs
pages and updated the choice-card-control styles. (by
[@oliverschuerch](https://github.com/oliverschuerch) with
[#2847](#2847))

- Fixed high-contrast-mode for card-control component. (by
[@oliverschuerch](https://github.com/oliverschuerch) with
[#2995](#2995))

- Added missing focus ring on checkbox and radio button groups. (by
[@alizedebray](https://github.com/alizedebray) with
[#3063](#3063))

## @swisspost/[email protected]

### Patch Changes

- Fixed display issue with long user/company names being cut off in the
user dropdown. (by [@alizedebray](https://github.com/alizedebray) with
[#3071](#3071))
-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]



## @swisspost/[email protected]

### Minor Changes

- Added a `heading-level` property on the `post-accordion` component to
set the heading level of all `post-accordion-item` children at once. (by
[@alizedebray](https://github.com/alizedebray) with
[#3067](#3067))

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Minor Changes

- Added the option for a Button animation to the left. (by
[@davidritter-dotcom](https://github.com/davidritter-dotcom) with
[#2865](#2865))

### Patch Changes

- Updated storybook version to 8 (by
[@renovate](https://github.com/apps/renovate) with
[#2797](#2797))

- Updated the post-accordion documentation: explicitly set the
`collapsed` property to `true`, simplified `collapsed` property usage
examples, and corrected misnamed `close-others` property to `multiple`.
(by [@alizedebray](https://github.com/alizedebray) with
[#3066](#3066))

- Merged the card-control, checkbox-card and radio button card docs
pages and updated the choice-card-control styles. (by
[@oliverschuerch](https://github.com/oliverschuerch) with
[#2847](#2847))

- Fixed high-contrast-mode for card-control component. (by
[@oliverschuerch](https://github.com/oliverschuerch) with
[#2995](#2995))

- Fixed the product card border missing in the documentation page. (by
[@alizedebray](https://github.com/alizedebray) with
[#3057](#3057))

-   Updated dependencies:
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

- Merged the card-control, checkbox-card and radio button card docs
pages and updated the choice-card-control styles. (by
[@oliverschuerch](https://github.com/oliverschuerch) with
[#2847](#2847))

- Fixed high-contrast-mode for card-control component. (by
[@oliverschuerch](https://github.com/oliverschuerch) with
[#2995](#2995))

-   Updated dependencies:
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Alizé Debray <[email protected]>
Co-authored-by: Alizé Debray <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button group: focus invisible if radio buttons or checkboxes
3 participants