Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(documentation): update CSS card-control styles and merge docs pages with the one from the web-component #2847

Conversation

oliverschuerch
Copy link
Contributor

No description provided.

…eb_components

# Conflicts:
#	packages/components/src/components.d.ts
@oliverschuerch oliverschuerch force-pushed the chore/2674-merge-docs-pages-of-card-control-components-into-one-with-tabs branch from 7396664 to e189762 Compare April 5, 2024 06:28
@oliverschuerch
Copy link
Contributor Author

Radio type is quite different from the following PR (we should discuss what is the right way): #2774 https://preview-2774--swisspost-design-system-next.netlify.app/?path=/docs/d83829b2-7de2-48d2-be64-07a80c9caef3--docs#validation-messages

On hover, the SelectedItem color is removed, is it correct?

Disabled style is as well different from (color + inner circle is filled with white in your version) : #2813 https://preview-2813--swisspost-design-system-next.netlify.app/?path=/docs/151242aa-a074-4a55-a81c-db597c83cdad--docs

On Firefox, the contrast with the label is not sufficient: firefox_b0loouslkD

Maybe we can talk about all this in the roundtable?

I think I found a satisfying solution for the hcm styles. Please have a look 😀

@oliverschuerch oliverschuerch requested a review from imagoiq April 5, 2024 06:32
@imagoiq imagoiq removed their request for review April 8, 2024 10:45
…components-into-one-with-tabs

# Conflicts:
#	packages/documentation/src/stories/components/card-control/card-control-methods.sample.ts
#	packages/documentation/src/stories/components/card-control/card-control.snapshot.stories.ts
#	packages/documentation/src/stories/components/card-control/card-control.stories.ts
#	packages/documentation/src/stories/components/forms/card-control/card-control-methods.sample.ts
#	packages/documentation/src/stories/components/forms/card-control/card-control.docs.mdx
#	packages/documentation/src/stories/components/forms/card-control/card-control.snapshot.stories.ts
#	packages/documentation/src/stories/components/forms/card-control/card-control.stories.ts
#	packages/documentation/src/stories/components/forms/card-control/card-control.styles.scss
#	packages/documentation/src/stories/components/forms/card-control/web-component/card-control-methods.sample.ts
#	packages/documentation/src/stories/components/forms/card-control/web-component/card-control.snapshot.stories.ts
#	packages/documentation/src/stories/components/forms/card-control/web-component/card-control.stories.ts
#	packages/documentation/src/stories/components/forms/choice-card/checkbox-card.docs.mdx
#	packages/documentation/src/stories/components/forms/choice-card/checkbox-card.stories.ts
#	packages/documentation/src/stories/components/forms/choice-card/radiobutton-card.docs.mdx
#	packages/documentation/src/stories/components/forms/choice-card/radiobutton-card.stories.ts
Copy link
Contributor

@imagoiq imagoiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In HCM on Firefox and hover state, the check has not enough contrast and the border of the checkbox is not visible anymore.

firefox_HDus3PCFNF

pnpm-lock.yaml Outdated Show resolved Hide resolved
…components-into-one-with-tabs

# Conflicts:
#	packages/documentation/src/stories/components/forms/card-control/card-control.docs.mdx
@oliverschuerch
Copy link
Contributor Author

To fix the hcm styles, I've created a new ticket: #2982

@oliverschuerch oliverschuerch requested a review from imagoiq April 19, 2024 08:07
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@oliverschuerch oliverschuerch merged commit a1a73b7 into main Apr 24, 2024
9 checks passed
@oliverschuerch oliverschuerch deleted the chore/2674-merge-docs-pages-of-card-control-components-into-one-with-tabs branch April 24, 2024 11:29
alizedebray added a commit that referenced this pull request May 23, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @swisspost/[email protected]

### Minor Changes

- Added a `heading-level` property on the `post-accordion` component to
set the heading level of all `post-accordion-item` children at once. (by
[@alizedebray](https://github.com/alizedebray) with
[#3067](#3067))

### Patch Changes

- Merged the card-control, checkbox-card and radio button card docs
pages and updated the choice-card-control styles. (by
[@oliverschuerch](https://github.com/oliverschuerch) with
[#2847](#2847))

- Fixed high-contrast-mode for card-control component. (by
[@oliverschuerch](https://github.com/oliverschuerch) with
[#2995](#2995))

- Fixed the `post-accordion-item` chevron no longer rotating. (by
[@alizedebray](https://github.com/alizedebray) with
[#3081](#3081))

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Minor Changes

- Added a `heading-level` property on the `post-accordion` component to
set the heading level of all `post-accordion-item` children at once. (by
[@alizedebray](https://github.com/alizedebray) with
[#3067](#3067))

## @swisspost/[email protected]

### Minor Changes

- Added icon number 2585. (by
[@swisspost-bot](https://github.com/swisspost-bot) with
[#3018](#3018))

- Added icons number 2586, 2587 and 2588. (by
[@swisspost-bot](https://github.com/swisspost-bot) with
[#3077](#3077))

## @swisspost/[email protected]

### Minor Changes

- Added the option for a Button animation to the left. (by
[@davidritter-dotcom](https://github.com/davidritter-dotcom) with
[#2865](#2865))

### Patch Changes

- Fixed missing chevron in valid and invalid select entries. (by
[@alizedebray](https://github.com/alizedebray) with
[#3075](#3075))

- Updated popover styles. - Removed popover `min-width` and updated
`max-width`.

    -   Simplyfied popover arrow size definition.
- Removed `:focus` selector fom `.text-auto` utility class (by
[@imagoiq](https://github.com/imagoiq) with
[#2926](#2926))

- Merged the card-control, checkbox-card and radio button card docs
pages and updated the choice-card-control styles. (by
[@oliverschuerch](https://github.com/oliverschuerch) with
[#2847](#2847))

- Fixed high-contrast-mode for card-control component. (by
[@oliverschuerch](https://github.com/oliverschuerch) with
[#2995](#2995))

- Added missing focus ring on checkbox and radio button groups. (by
[@alizedebray](https://github.com/alizedebray) with
[#3063](#3063))

## @swisspost/[email protected]

### Patch Changes

- Fixed display issue with long user/company names being cut off in the
user dropdown. (by [@alizedebray](https://github.com/alizedebray) with
[#3071](#3071))
-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]



## @swisspost/[email protected]

### Minor Changes

- Added a `heading-level` property on the `post-accordion` component to
set the heading level of all `post-accordion-item` children at once. (by
[@alizedebray](https://github.com/alizedebray) with
[#3067](#3067))

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Minor Changes

- Added the option for a Button animation to the left. (by
[@davidritter-dotcom](https://github.com/davidritter-dotcom) with
[#2865](#2865))

### Patch Changes

- Updated storybook version to 8 (by
[@renovate](https://github.com/apps/renovate) with
[#2797](#2797))

- Updated the post-accordion documentation: explicitly set the
`collapsed` property to `true`, simplified `collapsed` property usage
examples, and corrected misnamed `close-others` property to `multiple`.
(by [@alizedebray](https://github.com/alizedebray) with
[#3066](#3066))

- Merged the card-control, checkbox-card and radio button card docs
pages and updated the choice-card-control styles. (by
[@oliverschuerch](https://github.com/oliverschuerch) with
[#2847](#2847))

- Fixed high-contrast-mode for card-control component. (by
[@oliverschuerch](https://github.com/oliverschuerch) with
[#2995](#2995))

- Fixed the product card border missing in the documentation page. (by
[@alizedebray](https://github.com/alizedebray) with
[#3057](#3057))

-   Updated dependencies:
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

- Merged the card-control, checkbox-card and radio button card docs
pages and updated the choice-card-control styles. (by
[@oliverschuerch](https://github.com/oliverschuerch) with
[#2847](#2847))

- Fixed high-contrast-mode for card-control component. (by
[@oliverschuerch](https://github.com/oliverschuerch) with
[#2995](#2995))

-   Updated dependencies:
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Alizé Debray <[email protected]>
Co-authored-by: Alizé Debray <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge docs pages of card-control components into one with tabs
4 participants