Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(documentation-v7): add select snapshot test #1817

Merged
merged 9 commits into from
Aug 17, 2023
Merged

feat(documentation-v7): add select snapshot test #1817

merged 9 commits into from
Aug 17, 2023

Conversation

b1aserlu
Copy link
Contributor

image

Sometimes the disabled multiple version looks like in the picture. Not sure what we can do about that.

@b1aserlu b1aserlu requested a review from gfellerph as a code owner August 17, 2023 07:39
@b1aserlu b1aserlu linked an issue Aug 17, 2023 that may be closed by this pull request
Style: Visual regression tests for select #1168
Closed
@changeset-bot
Copy link

changeset-bot bot commented Aug 17, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 353e73b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Aug 17, 2023 •
edited
Loading

Preview environment ready: https://preview-1817--swisspost-design-system-next-v7.netlify.app

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@oliverschuerch oliverschuerch added the 📦 styles Related to the @swisspost/design-system-styles package label Aug 17, 2023
@oliverschuerch oliverschuerch added this to the Maintenance milestone Aug 17, 2023
@oliverschuerch oliverschuerch added the 🐞 bug Something isn't working label Aug 17, 2023
@gfellerph gfellerph added the 📦 migrations Related to the @swisspost/design-system-migrations package label Aug 17, 2023
@oliverschuerch
Copy link
Contributor

image

Sometimes the disabled multiple version looks like in the picture. Not sure what we can do about that.

This is probably a bug in the dark mode (which we don't have to support right now).
Create a bug ticket where you write down the findings, and we're fine.

@b1aserlu b1aserlu mentioned this pull request Aug 17, 2023
Closed
@b1aserlu b1aserlu removed 🐞 bug Something isn't working 📦 styles Related to the @swisspost/design-system-styles package labels Aug 17, 2023
@gfellerph gfellerph merged commit e2f3357 into main Aug 17, 2023
@gfellerph gfellerph deleted the 1168-style-visual-regression-tests-for-select branch August 17, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfellerph gfellerph gfellerph approved these changes

@oliverschuerch oliverschuerch Awaiting requested review from oliverschuerch

@alizedebray alizedebray Awaiting requested review from alizedebray

@imagoiq imagoiq Awaiting requested review from imagoiq

Assignees
No one assigned
Labels
📦 migrations Related to the @swisspost/design-system-migrations package
Projects
Design System Production Board
Archived in project
Milestone
Maintenance
Development

Successfully merging this pull request may close these issues.

Style: Visual regression tests for select
4 participants
@b1aserlu @swisspost-bot @oliverschuerch @gfellerph