Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style: Visual regression tests for select #1168

Closed
8 tasks done
gfellerph opened this issue Feb 23, 2023 · 0 comments · Fixed by #1817
Closed
8 tasks done

Style: Visual regression tests for select #1168

gfellerph opened this issue Feb 23, 2023 · 0 comments · Fixed by #1817
Assignees
@b1aserlu
Labels
📦 styles Related to the @swisspost/design-system-styles package
Milestone
Visual Regression...

Comments

@gfellerph
Copy link
Member

gfellerph commented Feb 23, 2023 •
edited by oliverschuerch
Loading

Write visual regression tests for the select component.

Create a storybook page similar to the button test page that shows all variants on one page. In the snapshot test, navigate to this page and take one snapshot of all variants at once.

Properties to test
Preview Give feedback
@gfellerph gfellerph added the 📦 styles Related to the @swisspost/design-system-styles package label Feb 23, 2023
@gfellerph gfellerph added this to the Visual Regression Tests milestone Feb 23, 2023
@gfellerph gfellerph added the pibs label Aug 9, 2023
@oliverschuerch oliverschuerch added 📦 migrations Related to the @swisspost/design-system-migrations package storybook 📦 styles Related to the @swisspost/design-system-styles package and removed 📦 styles Related to the @swisspost/design-system-styles package 📦 migrations Related to the @swisspost/design-system-migrations package labels Aug 15, 2023
@b1aserlu b1aserlu self-assigned this Aug 15, 2023
@b1aserlu b1aserlu moved this from 📋 Backlog to 🏗 In progress in Design System Production Board Aug 15, 2023
@b1aserlu b1aserlu assigned oliverschuerch and unassigned b1aserlu Aug 16, 2023
@b1aserlu b1aserlu linked a pull request Aug 17, 2023 that will close this issue
feat(documentation-v7): add select snapshot test #1817
Merged
@b1aserlu b1aserlu moved this from 🏗 In progress to 👀 In review in Design System Production Board Aug 17, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Design System Production Board Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@b1aserlu b1aserlu

Labels
📦 styles Related to the @swisspost/design-system-styles package
Projects
Design System Production Board
Archived in project
Milestone
Visual Regression Tests
Development

Successfully merging a pull request may close this issue.

feat(documentation-v7): add select snapshot test swisspost/design-system
3 participants
@gfellerph @oliverschuerch @b1aserlu