Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use update-checkout to pull swift dependencies #801

Merged
merged 9 commits into from
Oct 23, 2023
Merged

Use update-checkout to pull swift dependencies #801

merged 9 commits into from
Oct 23, 2023

Conversation

justice-adams-apple
Copy link
Contributor

@justice-adams-apple justice-adams-apple commented Apr 18, 2023 •
edited
Loading

Pull Request Description

  • Use update-checkout to reduce work related to keeping swift dependencies up to date for compiler builds

This will allow us to have 1 location to update when dependency updates are needed, eliminating the need for PR's such as #799 or #796

@justice-adams-apple
Copy link
Contributor Author

@swift-ci test

@justice-adams-apple justice-adams-apple changed the title [WIP] use update-checkout to pull swift dependencies Use update-checkout to pull swift dependencies Apr 19, 2023
@justice-adams-apple
Copy link
Contributor Author 

========================================
Failures:
  FAIL: swift-distributed-actors, 5.7, e024c1, Swift Package
========================================

This is unrelated, will open a PR for this xfail separately (apple/swift-distributed-actors#1113)

@ktoso
Copy link
Contributor

ktoso commented Apr 25, 2023

Rather than xfailing this consistently can we fix the build runner to allow passing -enable-testing? This has been a consistent painpoint for projects that didn't adopt "SPI" style

@justice-adams-apple
Copy link
Contributor Author

@swift-ci test

@ktoso
Copy link
Contributor

ktoso commented Apr 27, 2023

Awesome, passed! Thank you @justice-adams-apple !

@justice-adams-apple
Copy link
Contributor Author

@ahoppen Wanted to run this by you before merging since it changes the run_sk_stress_test logic

ahoppen
ahoppen requested changes May 9, 2023
View reviewed changes
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d like to hold this back for a couple more days because today I got the first successful stress tester run after several weeks and it found a number of failures. So, I’d like to stabilize the stress tester first before potentially destabilizing it again (filing issues and creating XFails). Once the stress tester is passing again (because I filed all the XFails or we fixed the underlying issues), we can merge this.

@justice-adams-apple
Copy link
Contributor Author

@swift-ci test

1 similar comment
@justice-adams-apple
Copy link
Contributor Author

@swift-ci test

@justice-adams-apple
Copy link
Contributor Author

@swift-ci test

@shahmishal shahmishal merged commit 119d9e0 into main Oct 23, 2023
1 check passed
@shahmishal shahmishal deleted the PR/use-checkout-script branch October 23, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahoppen ahoppen ahoppen approved these changes

@shahmishal shahmishal shahmishal approved these changes

@ktoso ktoso ktoso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@justice-adams-apple @ktoso @shahmishal @ahoppen