Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActorTestKit uses @testable import DistributedCluster, causing problems for build -c release #1113

Open
ktoso opened this issue Mar 2, 2023 · 2 comments
Labels
1 - triaged Ticket makes sense and is well defined, ready to be worked on

Comments

@ktoso
Copy link
Member

ktoso commented Mar 2, 2023

The testkit inherently DOES pry into a lot of the actor runtime internals of the cluster. It provides mocks and test probes and various things that pretend to be behavior actors but are not.

This needs to use internal APIs, and we do so by using a @testable import in the TestKit.
Making it not need that is a painful task making a lot of "old runtime" types public, which we absolutely don't want to do, given that now actors and distributed actors are in the language, so we would not want to expose MORE of our previous infrastructure.

If we had the package access visibility this would solve the issue. https://forums.swift.org/t/se-0386-package-access-modifier/62808/

This prevents the source-compatibility-suite to build the cluster in release mode.

@ktoso ktoso added the 1 - triaged Ticket makes sense and is well defined, ready to be worked on label Mar 2, 2023
@ktoso
Copy link
Member Author

ktoso commented Mar 2, 2023

Related issue rdar://106086239

@ktoso
Copy link
Member Author

ktoso commented Mar 2, 2023

Ah, we can move to @_spi(ActorTestKit) and that should work, excellent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - triaged Ticket makes sense and is well defined, ready to be worked on
Projects
None yet
Development

No branches or pull requests

1 participant