Simplify code (open-telemetry#2491)

swetharavichandrancisco · Oct 18, 2021 · 84bdf38 · 84bdf38
1 parent d119447
commit 84bdf38
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 36 deletions.
diff --git a/src/OpenTelemetry/Metrics/DropConfiguration.cs b/src/OpenTelemetry/Metrics/DropConfiguration.cs
diff --git a/src/OpenTelemetry/Metrics/MetricStreamConfiguration.cs b/src/OpenTelemetry/Metrics/MetricStreamConfiguration.cs
@@ -41,5 +41,14 @@ public class MetricStreamConfiguration
         public virtual Aggregation Aggregation { get; set; }
 
         // TODO: MetricPoints caps can be configured here
+
+        private sealed class DropConfiguration : MetricStreamConfiguration
+        {
+            public override Aggregation Aggregation
+            {
+                get => Aggregation.Drop;
+                set { }
+            }
+        }
     }
 }
diff --git a/test/OpenTelemetry.Tests/Metrics/MetricViewTests.cs b/test/OpenTelemetry.Tests/Metrics/MetricViewTests.cs
@@ -370,7 +370,8 @@ public void ViewToDropAndRetainInstrument()
         [Fact]
         public void MetricStreamConfigurationForDropMustNotAllowOverriding()
         {
-            Assert.Throws<ArgumentException>(() => MetricStreamConfiguration.Drop.Aggregation = Aggregation.Histogram);
+            MetricStreamConfiguration.Drop.Aggregation = Aggregation.Histogram;
+            Assert.Equal(Aggregation.Drop, MetricStreamConfiguration.Drop.Aggregation);
         }
     }
 #pragma warning restore SA1000 // KeywordsMustBeSpacedCorrectly