Simplify code #2491
Merged
Simplify code #2491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanwest
approved these changes
Oct 16, 2021
| public override Aggregation Aggregation | ||
| { | ||
| get => Aggregation.Drop; | ||
| set { } |
There was a problem hiding this comment.
A good thinking. I like it. There's just a test that needs fixing that asserts an exception is thrown.
Codecov Report
@@ Coverage Diff @@
## main #2491 +/- ##
==========================================
- Coverage 79.88% 79.88% -0.01%
==========================================
Files 254 253 -1
Lines 8570 8569 -1
==========================================
- Hits 6846 6845 -1
Misses 1724 1724
|
pellared
approved these changes
Oct 18, 2021
cijothomas
approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved
DropConfigurationintoMetricStreamConfigurationclass.Changed
DropConfigurationto private sealed.Removed the throw (which seems unnecessary).