Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace custom Diff type with new built-in Exclude type #43

Merged
merged 1 commit into from
Jun 18, 2018
Merged

Replace custom Diff type with new built-in Exclude type #43

merged 1 commit into from
Jun 18, 2018

Conversation

limonte
Copy link
Member

@limonte limonte commented Jun 18, 2018 •
edited
Loading

Fixes #39

Looks like there's no need in type Diff anymore and it could be replaced with the new built-in Exclude type.

The solution is copy-pasted from microsoft/TypeScript#12215 (comment)

From https://www.typescriptlang.org/docs/handbook/release-notes/typescript-2-8.html

Note: The Exclude type is a proper implementation of the Diff type suggested here. We’ve used the name Exclude to avoid breaking existing code that defines a Diff, plus we feel that name better conveys the semantics of the type.

@limonte limonte requested review from toverux and zenflow June 18, 2018 12:39
@limonte limonte force-pushed the types/type-overwrite branch from d6af11d to 6af7451 Compare June 18, 2018 12:40
@coveralls
Copy link

coveralls commented Jun 18, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 304

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.727%
Totals Coverage Status
Change from base Build 260: 0.0%
Covered Lines: 32
Relevant Lines: 32
💛 - Coveralls

@limonte limonte mentioned this pull request Jun 18, 2018
Closed
zenflow
zenflow approved these changes Jun 18, 2018
View reviewed changes
Copy link
Member

@zenflow zenflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Probably @toverux will not have a chance to review, so feel free to merge (and enjoy the splendor of semantic-release making the patch release hehe)

@zenflow
Copy link
Member

zenflow commented Jun 18, 2018

Thanks @limonte for tackling this one

@limonte limonte merged commit 973b68b into master Jun 18, 2018
@zenflow
Copy link
Member

zenflow commented Jun 18, 2018

🎉 This PR is included in version 1.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@limonte
Copy link
Member Author

limonte commented Jun 18, 2018

Splendor indeed, love it! The CI build is great green again!

@zenflow zenflow mentioned this pull request Jun 18, 2018
Closed
@zenflow zenflow deleted the types/type-overwrite branch June 21, 2018 16:04
limonte added a commit that referenced this pull request Nov 6, 2022
@limonte
fix(typescript): replace Diff type with new built-in Exclude type (#43)
101145c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zenflow zenflow zenflow approved these changes

@toverux toverux Awaiting requested review from toverux

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@limonte @coveralls @zenflow