-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The current master is failing in CI #39
Comments
@zenflow @toverux are you planning to maintain this project? If so, this issue should be fixed asap because:
Let's stay the outstanding example of how OSS should be made and not join the vast majority of repositories which were published and then abandoned (Good Luck With That Public License). |
@limonte Yes, I do plan to maintain this project. Excuse for being absent: My laptop died while I was travelling in South America. It's not an ideal place to buy a new laptop because of duties on imports, and also I've been doing travel things. To make matters worse I was robbed in Chile and lost my credit and debit card (making it difficult to make a large purchase). But as of yesterday, I'm in Buenos Aires in a new apartment with my girlfriend, for the next 2.5 months, and I have a new laptop (thanks! 😃😃😃). So I aim to resolve this tomorrow. |
Because of this issue and #33, I was thinking of just removing TS support for now. I think the implementation is less than ideal right now anyways (just guessing), since it was done before the object-oriented refactor of SweetAlert2 and subsequently this library. I think it will have to be redone to be proper anyways. Sorry @toverux for not having the foresight about this. If there's no objection to this then I'll make a PR tomorrow and leave it for a day or two to give @toverux a chance to intervene, though he seems to be busy. |
🎉 This issue has been resolved in version 1.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
https://travis-ci.org/sweetalert2/sweetalert2-react-content/builds/390371045
@toverux would you mind to take a look on this issue?
The text was updated successfully, but these errors were encountered: