Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all V1 functionality #24

Merged
merged 5 commits into from
Jun 30, 2019
Merged

Remove all V1 functionality #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9ac9a29
Remove Endpoints::InflectionEndpoint
swcraig Jun 30, 2019
33c1581
Remove OxfordDictionary::DeprecatedRequest
swcraig Jun 30, 2019
b93c84d
Remove V1 support in spec_helper
swcraig Jun 30, 2019
9bc5862
Remove all V1 entities
swcraig Jun 30, 2019
d1c4e2c
Remove OxfordDictionary::Error
swcraig Jun 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions lib/oxford_dictionary/api_objects/entry.rb
View file
Open in desktop

This file was deleted.

12 changes: 0 additions & 12 deletions lib/oxford_dictionary/api_objects/entry_response.rb
View file
Open in desktop

This file was deleted.

16 changes: 0 additions & 16 deletions lib/oxford_dictionary/api_objects/lexical_entry.rb
View file
Open in desktop

This file was deleted.

7 changes: 0 additions & 7 deletions lib/oxford_dictionary/api_objects/list_response.rb
View file
Open in desktop

This file was deleted.

10 changes: 0 additions & 10 deletions lib/oxford_dictionary/api_objects/pronunciation.rb
View file
Open in desktop

This file was deleted.

19 changes: 0 additions & 19 deletions lib/oxford_dictionary/api_objects/sense.rb
View file
Open in desktop

This file was deleted.

127 changes: 0 additions & 127 deletions lib/oxford_dictionary/deprecated_request.rb
View file
Open in desktop

This file was deleted.

23 changes: 0 additions & 23 deletions lib/oxford_dictionary/endpoints/inflection_endpoint.rb
View file
Open in desktop

This file was deleted.

10 changes: 0 additions & 10 deletions lib/oxford_dictionary/error.rb
View file
Open in desktop

This file was deleted.

32 changes: 0 additions & 32 deletions spec/spec_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,38 +12,6 @@
config.filter_sensitive_data('APP_KEY') { |request| ENV['APP_KEY'] }
end

TEST_API_ID = 'ID'.freeze
TEST_API_KEY = 'SECRET'.freeze
ACCEPT = 'application/json'.freeze
HEADERS = { 'Accept' => ACCEPT, 'App-Id' => 'ID', 'App-Key' => 'SECRET' }.freeze

def stub_get(path, fixture_name)
headers = HEADERS
stub_request(:get, api_url(path))
.with(headers: headers)
.to_return(status: 200, body: fixture(fixture_name))
end

def stub_error(path, fixture_name)
headers = HEADERS
stub_request(:get, api_url(path))
.with(headers: headers)
.to_return(status: 404, body: fixture(fixture_name))
end

def fixture_path(file = nil)
path = File.expand_path('../fixtures', __FILE__)
file.nil? ? path : File.join(path, file)
end

def fixture(file)
File.read(fixture_path(file))
end

def api_url(path)
"#{OxfordDictionary::DeprecatedRequest::BASE}/#{path}"
end

RSpec.configure do |config|
config.expect_with :rspec do |c|
c.syntax = :expect
Expand Down