Remove all V1 functionality #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should have been removed as part of #21.
This was only used by the V1 endpoints which have all been removed.
We use VCR instead of this hand-rolled stubbing nonsense.
Instead of parsing the JSON response from the API into one of these entities we instead parse the response into a nested OpenStruct. Reference OxfordDictionary::Deserialize to see the implementation.
Instead of using this for V2, if the API gives us a 404 the OpenStruct we translate the response into will have an `error` key with the relevant messaging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oxford Dictionaries has made a V2 upgrade to their API and will be
taking their V1 API offline on June 30, 2019.
Reference the following PRs for the new usage: