Add OxfordDictionary::Endpoints::Sentences #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oxford Dictionaries is updating their API to a new version which includes quite a few changes: https://developer.oxforddictionaries.com/version2 They are moving the sentences functionality to its own endpoint (instead of having part of the entries endpoint). As mentioned in the tests, this only unit tests the endpoint. If someone would like to contribute, please feel free to update and run the specs (similar to what was done for the Entries and Lemmas endpoints). Entries: #8 Lemmas: #10
Oxford Dictionaries is updating their API to a new version which includes quite a few changes: https://developer.oxforddictionaries.com/version2 They are moving the sentences functionality to its own endpoint (instead of having part of the entries endpoint). This should be used instead of `Client#entry_sentences`.
Oxford Dictionaries is updating their API to a new version which includes quite a few changes: https://developer.oxforddictionaries.com/version2 They are moving the sentences functionality to its own endpoint (instead of having part of the entries endpoint). Use `Client#sentence` instead.
swcraig
force-pushed
the
v2-sentences-endpoint
branch
from
8d712e4 to
4ae8eda
Compare
swcraig
added a commit
that referenced
this pull request
Jun 23, 2019
Oxford Dictionaries is updating their API to a new version which includes quite a few changes: https://developer.oxforddictionaries.com/version2 Oxford Dictionaries is taking their V1 API offline on June 30, 2019. The deprecation warnings (please check the closed PRs online which include them) should give an idea on how users should update their applications to use the new V2 interfaces. All V2 interfaces use named parameters and specifically leverage their `params` arguments for more control over how the endpoints are called. Check out [Oxford Dictionaries' online documentation] (https://developer.oxforddictionaries.com/documentation), the specs, and the commit messages for the V2 endpoints for more information. v1.3.0 does not include a README update (I will do that when I cut v2.0.0). The 2.0.0 of this library will include the removal of all V1 interfaces. The V2 interfaces for this library are in the following PRs: Entries: #8 Translations: #12 Sentences: #13 Thesaurus: #14 Lemmas: #10 Search: #15
Merged
swcraig
added a commit
that referenced
this pull request
Jun 23, 2019
Oxford Dictionaries is updating their API to a new version which includes quite a few changes: https://developer.oxforddictionaries.com/version2 Oxford Dictionaries is taking their V1 API offline on June 30, 2019. The deprecation warnings (please check the closed PRs online which include them) should give an idea on how users should update their applications to use the new V2 interfaces. All V2 interfaces use named parameters and specifically leverage their `params` arguments for more control over how the endpoints are called. Check out [Oxford Dictionaries' online documentation] (https://developer.oxforddictionaries.com/documentation), the specs, and the commit messages for the V2 endpoints for more information. v1.3.0 does not include a README update (I will do that when I cut v2.0.0). The 2.0.0 of this library will include the removal of all V1 interfaces. The V2 interfaces for this library are in the following PRs: Entries: #8 Translations: #12 Sentences: #13 Thesaurus: #14 Lemmas: #10 Search: #15
swcraig
added a commit
that referenced
this pull request
Jun 23, 2019
Oxford Dictionaries is updating their API to a new version which includes quite a few changes: https://developer.oxforddictionaries.com/version2 Oxford Dictionaries is taking their V1 API offline on June 30, 2019. The deprecation warnings (please check the closed PRs online which include them) should give an idea on how users should update their applications to use the new V2 interfaces. All V2 interfaces use named parameters and specifically leverage their `params` arguments for more control over how the endpoints are called. Check out [Oxford Dictionaries' online documentation] (https://developer.oxforddictionaries.com/documentation), the specs, and the commit messages for the V2 endpoints for more information. v1.3.0 does not include a README update (I will do that when I cut v2.0.0). The 2.0.0 of this library will include the removal of all V1 interfaces. The V2 interfaces for this library are in the following PRs: Entries: #8 Translations: #12 Sentences: #13 Thesaurus: #14 Lemmas: #10 Search: #15
swcraig
added a commit
that referenced
this pull request
Jun 30, 2019
Oxford Dictionaries has discontinued their V1 API (it will be taken offline on June 30, 2019). As part of the upgrade of this wrapper the new interface uses named parameters. Reference the following PRs for the new usage: - Entries: #8 - Translations: #12 - Sentences: #13 - Thesaurus: #14 - Lemmas: #10 - Search: #15 All of the response objects are OpenStructs with camelCase keys. This is a departure from V1 (which used snake_case keys in the response).
swcraig
added a commit
that referenced
this pull request
Jun 30, 2019
Oxford Dictionaries has discontinued their V1 API (it will be taken offline on June 30, 2019). As part of the upgrade of this wrapper the new interface uses named parameters. Reference the following PRs for the new usage: - Entries: #8 - Translations: #12 - Sentences: #13 - Thesaurus: #14 - Lemmas: #10 - Search: #15 All of the response objects are OpenStructs with camelCase keys. This is a departure from V1 (which used snake_case keys in the response).
swcraig
added a commit
that referenced
this pull request
Jun 30, 2019
Oxford Dictionaries has made a V2 upgrade to their API and will be taking their V1 API offline on June 30, 2019. Reference the following PRs for the new usage: - Entries: #8 - Translations: #12 - Sentences: #13 - Thesaurus: #14 - Lemmas: #10 - Search: #15 This version uses the V2 endpoints exclusively.
Merged
swcraig
added a commit
that referenced
this pull request
Jun 30, 2019
Oxford Dictionaries has made a V2 upgrade to their API and will be taking their V1 API offline on June 30, 2019. Reference the following PRs for the new usage: - Entries: #8 - Translations: #12 - Sentences: #13 - Thesaurus: #14 - Lemmas: #10 - Search: #15 This version uses the V2 endpoints exclusively.
swcraig
added a commit
that referenced
this pull request
Jun 30, 2019
Oxford Dictionaries has made a V2 upgrade to their API and will be taking their V1 API offline on June 30, 2019. Reference the following PRs for the new usage: - Entries: #8 - Translations: #12 - Sentences: #13 - Thesaurus: #14 - Lemmas: #10 - Search: #15 This version uses the V2 endpoints exclusively.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oxford Dictionaries is updating their API to a new version which
includes quite a few changes:
https://developer.oxforddictionaries.com/version2
They are moving the sentences functionality to its own endpoint
(instead of having part of the entries endpoint).
As mentioned in the tests, this only unit tests the endpoint. If someone
would like to contribute, please feel free to update and run the specs
(similar to what was done for the Entries and Lemmas endpoints).
Entries: #8
Lemmas: #10