Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(preset-env): Upgrade browserslist-rs #9023

Merged
merged 9 commits into from
Jul 1, 2024
Merged

feat(preset-env): Upgrade browserslist-rs #9023

merged 9 commits into from
Jul 1, 2024

Conversation

g-plane
Copy link
Contributor

@g-plane g-plane commented Jun 5, 2024

Description:

Compilation time of browserslist-rs has beed reduced by 32%. See: browserslist/browserslist-rs#23

But, it's still slower that oxc-browserslist:

image

while browserslist-rs costs about 3.9s.

BREAKING CHANGE:

Related issue (if exists):

Close #9014

@chenjiahan
Copy link
Contributor

The CI is failed, can you take a look? ❤️

@g-plane
Copy link
Contributor Author

g-plane commented Jun 25, 2024

I failed to fix it. Let's ask help to @kdy1 .

kdy1
kdy1 previously approved these changes Jul 1, 2024
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • preset_env_base --breaking

@kdy1 kdy1 added this to the Planned milestone Jul 1, 2024
@kdy1 kdy1 self-assigned this Jul 1, 2024
@kdy1 kdy1 requested review from a team as code owners July 1, 2024 04:37
kdy1
kdy1 previously approved these changes Jul 1, 2024
@kdy1 kdy1 enabled auto-merge (squash) July 1, 2024 04:38
Copy link

socket-security bot commented Jul 1, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None 0 3.66 kB dougwilson

🚮 Removed packages: npm/@babel/[email protected], npm/[email protected]

View full report↗︎

@kdy1 kdy1 merged commit 18d6277 into swc-project:main Jul 1, 2024
147 checks passed
@kdy1
Copy link
Member

kdy1 commented Jul 1, 2024

  • cd crates/swc && time cargo build --release --features swc_ecma_minifier/concurrent

Before this PR:

    Finished `release` profile [optimized] target(s) in 37.52s
cargo build --release --features swc_ecma_minifier/concurrent  365.78s user 11.74s system 1004% cpu 37.592 total

After this PR:

    Finished `release` profile [optimized] target(s) in 38.98s
cargo build --release --features swc_ecma_minifier/concurrent  355.72s user 10.34s system 937% cpu 39.048 total

@g-plane
Copy link
Contributor Author

g-plane commented Jul 1, 2024

Does it look slower? That's weird.

@kdy1
Copy link
Member

kdy1 commented Jul 1, 2024

I think it's a noise

@kdy1 kdy1 removed this from the Planned milestone Jul 3, 2024
@kdy1 kdy1 added this to the v1.6.7 milestone Jul 3, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants