Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump browserslist-rs 0.16.0 #772

Merged

Conversation

chenjiahan
Copy link
Contributor

@chenjiahan
Copy link
Contributor Author

@mischnic I have fixed the CI, can you approve the workflow again? ❤️

@mischnic
Copy link
Member

There's apparently still a failing test:

---- bundler::tests::test_bundle stdout ----
thread 'bundler::tests::test_bundle' panicked at src/bundler.rs:1121:5:
assertion `left == right` failed
  left: "@supports (foo: bar) or (color: red) {\n  .b {\n    color: green;\n  }\n}\n\n.a {\n  color: red;\n}\n"
 right: "@supports (color: red) or (foo: bar) {\n  .b {\n    color: green;\n  }\n}\n\n.a {\n  color: red;\n}\n"
stack backtrace:
   0:     0x5577d2c86156 - std::backtrace_rs::backtrace::libunwind::trace::hbee8a7973eeb6c93
                               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/../../backtrace/src/backtrace/libunwind.rs:104:5
   1:     0x5577d2c86156 - std::backtrace_rs::backtrace::trace_unsynchronized::hc8ac75eea3aa6899
                               at 

@chenjiahan
Copy link
Contributor Author

I can not reproduce this failure in my device:

image

image

I'm not sure if this can be fixed by retry the CI, it would be great if you could help to confirm that.

@mischnic
Copy link
Member

mischnic commented Aug 1, 2024

@devongovett Sounds like some nondeterministic map/list? I guess this really shouldn't happen?

@devongovett
Copy link
Member

It's this, just haven't gotten around to fixing it #137

@devongovett devongovett merged commit 3e62347 into parcel-bundler:master Aug 1, 2024
3 checks passed
@chenjiahan chenjiahan deleted the bump_browserslist_rc_0714 branch August 1, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants