Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(es/compat): Implement stage 3 decorator, without auto accessor #6950

Merged
merged 118 commits into from
Apr 3, 2023

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Feb 16, 2023

Description:

Related issue:

@kdy1 kdy1 added this to the Planned milestone Feb 16, 2023
@kdy1 kdy1 self-assigned this Feb 16, 2023
kdy1 added a commit that referenced this pull request Feb 23, 2023
**Description:**

This is required for #6981 and #6950
@kdy1 kdy1 force-pushed the spec-decorator branch 2 times, most recently from bbcfcd8 to 76e17fc Compare March 10, 2023 04:41
@kdy1 kdy1 changed the title feat(es/compat): Implement stage 3 decorator feat(es/compat): Implement stage 3 decorator (without auto accessor support) Apr 3, 2023
@kdy1 kdy1 changed the title feat(es/compat): Implement stage 3 decorator (without auto accessor support) feat(es/compat): Implement stage 3 decorator, without auto accessor Apr 3, 2023
@kdy1 kdy1 marked this pull request as ready for review April 3, 2023 07:38
@kdy1 kdy1 enabled auto-merge (squash) April 3, 2023 07:38
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_transforms_base
  • swc_ecma_transforms_compat

Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_utils

@kdy1 kdy1 merged commit 7a863ad into swc-project:main Apr 3, 2023
@kdy1 kdy1 deleted the spec-decorator branch April 3, 2023 08:13
@yay
Copy link

yay commented Apr 3, 2023

Hi,

Thank you for doing this work! Super excited to get my hands on it once it's ready :)

Just noticed the title says without auto accessor. Wonder what this means for a use case like this (as mentioned in the proposal):

class Example {
  @reactive accessor myBool = false;
}

As far as I understand, this should still be possible without the accessor keyword, except the decorator function will have to define its own getter and setter, so pretty inconsequential that it's going to be missing, right?

@kdy1
Copy link
Member Author

kdy1 commented Apr 3, 2023

Yes, I'll work on auto accessor part in the future with another PR

@kdy1 kdy1 modified the milestones: Planned, v1.3.45 Apr 4, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators May 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants