Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to swc_ecma_parser 0.130 #138

Merged
merged 10 commits into from
Mar 20, 2023

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Mar 15, 2023

Tested downstream crates.

@dsherret dsherret marked this pull request as ready for review March 16, 2023 17:43
decorators: true,
// should be true for mts and cts:
// https://babeljs.io/docs/babel-preset-typescript#disallowambiguousjsxlike
disallow_ambiguous_jsx_like: matches!(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is new

@dsherret
Copy link
Member Author

dsherret commented Mar 16, 2023

Paused waiting on swc-project/swc#6950 (though we should still upgrade if that doesn't land in a while)

@dsherret dsherret marked this pull request as draft March 16, 2023 19:29
@dsherret dsherret marked this pull request as ready for review March 20, 2023 15:50
@dsherret
Copy link
Member Author

I'm going to continue the upgrade without decorators. PTAL.

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit 47fcf27 into denoland:main Mar 20, 2023
@dsherret dsherret deleted the feat_upgrade_swc_ecma_parser_0_130 branch March 20, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants